From: Georg Sauthoff <mail@georg.so>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Improve gcore shell quoting and portability
Date: Thu, 01 Mar 2018 19:48:00 -0000 [thread overview]
Message-ID: <20180301194802.GA27018@dell12.lru.li> (raw)
In-Reply-To: <6c710a6d-5d12-c2eb-4c11-9c28196f3866@simark.ca>
On Sun, Feb 25, 2018 at 05:41:40PM -0500, Simon Marchi wrote:
Hello,
[..]
> > # `</dev/null' to avoid touching interactive terminal if it is
> > # available but not accessible as GDB would get stopped on SIGTTIN.
> > - $binary_path/@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \
> > + "$binary_path"/@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \
> To be pedantic, I guess we would have to quote the whole path, since
> GDB_TRANSFORM_NAME could contain some spaces. It's not very likely, I agree,
> but it's also easy to change.
> If you are fine with the suggestions above, I could fix them and push the resulting
> patch, is that ok with you?
yes, I'm fine with all your suggestion.
I'm also a fan of the `#!/usr/bin/env someinterpreter` construct.
Thus, please go ahead.
Best regards
Georg
next prev parent reply other threads:[~2018-03-01 19:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 20:46 Georg Sauthoff
2018-02-25 22:41 ` Simon Marchi
2018-03-01 19:48 ` Georg Sauthoff [this message]
2018-03-01 22:30 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301194802.GA27018@dell12.lru.li \
--to=mail@georg.so \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox