From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-145708-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11548 invoked by alias); 1 Mar 2018 19:48:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 10950 invoked by uid 89); 1 Mar 2018 19:48:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*F:U*mail
X-HELO: georg.so
Received: from georg.so (HELO georg.so) (89.238.75.224) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Mar 2018 19:48:06 +0000
Received: from dell12.lru.li (unknown [IPv6:2001:1a80:303a:0:faca:b8ff:fe50:d072])	(Authenticated sender: georg)	by georg.so (Postfix) with ESMTPSA id DA7404AE9C0;	Thu,  1 Mar 2018 20:48:03 +0100 (CET)
Received: by dell12.lru.li (Postfix, from userid 1000)	id 2D3F21C3581; Thu,  1 Mar 2018 20:48:03 +0100 (CET)
Date: Thu, 01 Mar 2018 19:48:00 -0000
From: Georg Sauthoff <mail@georg.so>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Improve gcore shell quoting and portability
Message-ID: <20180301194802.GA27018@dell12.lru.li>
References: <20180225204601.19068-1-mail@georg.so> <6c710a6d-5d12-c2eb-4c11-9c28196f3866@simark.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6c710a6d-5d12-c2eb-4c11-9c28196f3866@simark.ca>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-SW-Source: 2018-03/txt/msg00037.txt.bz2

On Sun, Feb 25, 2018 at 05:41:40PM -0500, Simon Marchi wrote:

Hello,

[..]
> >  	# `</dev/null' to avoid touching interactive terminal if it is
> >  	# available but not accessible as GDB would get stopped on SIGTTIN.
> > -	$binary_path/@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \
> > +	"$binary_path"/@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \

> To be pedantic, I guess we would have to quote the whole path, since
> GDB_TRANSFORM_NAME could contain some spaces.  It's not very likely, I agree,
> but it's also easy to change.
 
> If you are fine with the suggestions above, I could fix them and push the resulting
> patch, is that ok with you?

yes, I'm fine with all your suggestion.

I'm also a fan of the `#!/usr/bin/env someinterpreter` construct.

Thus, please go ahead.

Best regards
Georg