From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedromfc@linux.vnet.ibm.com (Pedro Franco de Carvalho)
Cc: nikola.prica@rt-rk.com (Nikola Prica),
kevinb@redhat.com (Kevin Buettner),
gdb-patches@sourceware.org,
asowda@cisco.com ("Ananthakrishna Sowda \(asowda\)"),
ibaev@cisco.com ("Ivan Baev \(ibaev\)"),
nemanja.popov@rt-rk.com ('Nemanja Popov'),
Djordje.Todorovic@rt-rk.com (Djordje Todorovic),
Ulrich.Weigand@de.ibm.com
Subject: Re: [PING][PATCH] Fix for prologue processing on PowerPC
Date: Wed, 31 Jan 2018 18:28:00 -0000 [thread overview]
Message-ID: <20180131182812.CFA13D802DE@oc3748833570.ibm.com> (raw)
In-Reply-To: <87y3kdrjlm.fsf@linux.vnet.ibm.com> from "Pedro Franco de Carvalho" at Jan 31, 2018 04:03:49 PM
Pedro Franco de Carvalho wrote:
> Looks good to me. Just two details for the testsuite changelog,
> the filenames in the entry don't match the actual filenames, and there's
> a space between the "*" and the entries.
>
> I tested the patch with ppc64le and ppc32, and it works. No regressions.
>
> Thanks!
> Pedro
>
> Nikola Prica <nikola.prica@rt-rk.com> writes:
>
> > Hi Pedro,
> >
> > Thank you for your review and patience. I'm really grateful.
> >
> > Can someone commit this patch?
The patch looks good to me as well. Thanks for the review, Pedro!
I've checked this is now.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2018-01-31 18:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 12:11 Nikola Prica
2017-10-05 2:01 ` Kevin Buettner
2017-10-26 10:02 ` [PING]Fix " Nikola Prica
2017-11-08 16:58 ` Kevin Buettner
2017-11-09 18:15 ` [PING][PATCH] Fix " Nikola Prica
2017-12-01 19:37 ` pedromfc
2017-12-19 15:57 ` Nikola Prica
2017-12-29 18:05 ` Pedro Franco de Carvalho
2018-01-09 11:22 ` Nikola Prica
2018-01-10 17:26 ` Pedro Franco de Carvalho
2018-01-11 15:12 ` Nikola Prica
2018-01-19 7:49 ` Nikola Prica
2018-01-19 19:01 ` Pedro Franco de Carvalho
2018-01-19 19:08 ` Pedro Franco de Carvalho
2018-01-27 14:32 ` Nikola Prica
2018-01-31 18:04 ` Pedro Franco de Carvalho
2018-01-31 18:28 ` Ulrich Weigand [this message]
2018-02-01 13:09 ` Nikola Prica
2018-01-02 10:29 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180131182812.CFA13D802DE@oc3748833570.ibm.com \
--to=uweigand@de.ibm.com \
--cc=Djordje.Todorovic@rt-rk.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=asowda@cisco.com \
--cc=gdb-patches@sourceware.org \
--cc=ibaev@cisco.com \
--cc=kevinb@redhat.com \
--cc=nemanja.popov@rt-rk.com \
--cc=nikola.prica@rt-rk.com \
--cc=pedromfc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox