From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] Class-fy partial_die_info
Date: Thu, 25 Jan 2018 12:05:00 -0000 [thread overview]
Message-ID: <20180125120524.4q5zyi5jbpotof6n@adacore.com> (raw)
In-Reply-To: <1516873114-7449-1-git-send-email-yao.qi@linaro.org>
Hi Yao,
On Thu, Jan 25, 2018 at 09:38:27AM +0000, Yao Qi wrote:
> When I fix some issue related to dwarf, I class-fy partial_die_info as
> part of the fix. The class-fy bits can go upstream first.
>
> Regression tested on x86_64-linux.
>
> *** BLURB HERE ***
>
> Yao Qi (7):
> Re-write partial_die_info allocation in load_partial_dies
> Don't check abbrev is NULL in read_partial_die
> Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die
> Class-fy partial_die_info
> Remove one argument abbrev_len in read_partial_die
> Move fixup_partial_die to partial_die_info::fixup
> Move read_partial_die to partial_die_info::read
>
> gdb/dwarf2read.c | 339 ++++++++++++++++++++++++++++++-------------------------
> 1 file changed, 185 insertions(+), 154 deletions(-)
What's the advantage of turning this struct into a class?
Is it memory management?
(sorry if it's obvious from the code - C++ dummy, here)
--
Joel
next prev parent reply other threads:[~2018-01-25 12:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 9:38 Yao Qi
2018-01-25 9:38 ` [PATCH 7/7] Move read_partial_die to partial_die_info::read Yao Qi
2018-01-29 1:58 ` Simon Marchi
2018-01-25 9:38 ` [PATCH 4/7] Class-fy partial_die_info Yao Qi
[not found] ` <87vafphpw6.fsf@tromey.com>
2018-01-26 17:25 ` Yao Qi
2018-01-26 20:55 ` Tom Tromey
2018-01-29 1:15 ` Simon Marchi
2018-01-30 10:49 ` Yao Qi
2018-01-30 15:11 ` Pedro Alves
2018-01-30 11:39 ` Pedro Alves
2018-01-31 3:46 ` Simon Marchi
2018-01-31 11:55 ` Yao Qi
2018-01-31 15:33 ` Pedro Alves
2018-01-25 9:38 ` [PATCH 1/7] Re-write partial_die_info allocation in load_partial_dies Yao Qi
2018-01-25 9:38 ` [PATCH 2/7] Don't check abbrev is NULL in read_partial_die Yao Qi
2018-01-25 9:38 ` [PATCH 3/7] Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die Yao Qi
2018-01-25 9:38 ` [PATCH 6/7] Move fixup_partial_die to partial_die_info::fixup Yao Qi
2018-01-25 12:59 ` Pedro Alves
2018-01-25 14:45 ` Yao Qi
2018-01-25 9:38 ` [PATCH 5/7] Remove one argument abbrev_len in read_partial_die Yao Qi
2018-01-29 1:30 ` Simon Marchi
2018-01-25 12:05 ` Joel Brobecker [this message]
2018-01-25 14:03 ` [PATCH 0/7] Class-fy partial_die_info Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125120524.4q5zyi5jbpotof6n@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox