From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19254 invoked by alias); 25 Jan 2018 12:05:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19237 invoked by uid 89); 25 Jan 2018 12:05:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:968, HERE, management X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Jan 2018 12:05:30 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4006E560BA; Thu, 25 Jan 2018 07:05:29 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Pntj3KqOq2Ip; Thu, 25 Jan 2018 07:05:29 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CC48E5602A; Thu, 25 Jan 2018 07:05:28 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 767498330C; Thu, 25 Jan 2018 16:05:24 +0400 (+04) Date: Thu, 25 Jan 2018 12:05:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Class-fy partial_die_info Message-ID: <20180125120524.4q5zyi5jbpotof6n@adacore.com> References: <1516873114-7449-1-git-send-email-yao.qi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516873114-7449-1-git-send-email-yao.qi@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2018-01/txt/msg00517.txt.bz2 Hi Yao, On Thu, Jan 25, 2018 at 09:38:27AM +0000, Yao Qi wrote: > When I fix some issue related to dwarf, I class-fy partial_die_info as > part of the fix. The class-fy bits can go upstream first. > > Regression tested on x86_64-linux. > > *** BLURB HERE *** > > Yao Qi (7): > Re-write partial_die_info allocation in load_partial_dies > Don't check abbrev is NULL in read_partial_die > Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die > Class-fy partial_die_info > Remove one argument abbrev_len in read_partial_die > Move fixup_partial_die to partial_die_info::fixup > Move read_partial_die to partial_die_info::read > > gdb/dwarf2read.c | 339 ++++++++++++++++++++++++++++++------------------------- > 1 file changed, 185 insertions(+), 154 deletions(-) What's the advantage of turning this struct into a class? Is it memory management? (sorry if it's obvious from the code - C++ dummy, here) -- Joel