Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 3/5] gdb/copyright.py: Do not forget to remind about MULTIPLE_COPYRIGHT_HEADERS
Date: Mon, 01 Jan 2018 04:48:00 -0000	[thread overview]
Message-ID: <20180101044801.7201-4-brobecker@adacore.com> (raw)
In-Reply-To: <20180101044801.7201-1-brobecker@adacore.com>

There is a small logical error in the part of the script that
dumps the list of files in BY_HAND + MULTIPLE_COPYRIGHT_HEADERS
but only checkis the contents of BY_HAND. The issue becomes
apparent as soon as BY_HAND is empty. Prevent this from happening
by treating the two lists separately, as this allows us to provide
a more informative message in the case of MULTIPLE_COPYRIGHT_HEADERS.

gdb/ChangeLog:

        * copyright.py (main): Dump the contents of
        MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
        even if BY_HAND is empty.
---
 gdb/ChangeLog    |  6 ++++++
 gdb/copyright.py | 11 ++++++++++-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 929c513a78..27f7c7ffee 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
 
+	* copyright.py (main): Dump the contents of
+	MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
+	even if BY_HAND is empty.
+
+2018-01-01  Joel Brobecker  <brobecker@adacore.com>
+
 	* top.c (print_gdb_version): Update Copyright year in version
 	message.
 
diff --git a/gdb/copyright.py b/gdb/copyright.py
index dca2d56f98..bb21b21601 100644
--- a/gdb/copyright.py
+++ b/gdb/copyright.py
@@ -150,11 +150,20 @@ def main ():
     update_files (update_list)
 
     # Remind the user that some files need to be updated by HAND...
+
+    if MULTIPLE_COPYRIGHT_HEADERS:
+        print
+        print("\033[31m"
+              "REMINDER: Multiple copyright headers must be updated by hand:"
+              "\033[0m")
+        for filename in MULTIPLE_COPYRIGHT_HEADERS:
+            print "  ", filename
+
     if BY_HAND:
         print
         print "\033[31mREMINDER: The following files must be updated by hand." \
               "\033[0m"
-        for filename in BY_HAND + MULTIPLE_COPYRIGHT_HEADERS:
+        for filename in BY_HAND:
             print "  ", filename
 
 ############################################################################
-- 
2.11.0


  parent reply	other threads:[~2018-01-01  4:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-01  4:48 GDB "Start of New Year Procedure" -- 2018 edition Joel Brobecker
2018-01-01  4:48 ` [PATCH 4/5] gdb/copyright.py: Remove testsuite/gdb.base/step-line.{c,inp} special handling Joel Brobecker
2018-01-01  4:48 ` Joel Brobecker [this message]
2018-01-01  4:48 ` [PATCH 2/5] Update copyright year in version message of GDB, GDBserver and GDBreplay Joel Brobecker
2018-01-01  6:09 ` GDB "Start of New Year Procedure" -- 2018 edition Joel Brobecker
2018-01-02  6:13 ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180101044801.7201-4-brobecker@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox