From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54174 invoked by alias); 1 Jan 2018 04:48:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53966 invoked by uid 89); 1 Jan 2018 04:48:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.2 required=5.0 tests=AWL,BAYES_05,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=31m, H*MI:sk:2018010, Hx-languages-length:1939, joel X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Jan 2018 04:48:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6B12B11773C for ; Sun, 31 Dec 2017 23:48:11 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mc8HahWv3CyU for ; Sun, 31 Dec 2017 23:48:11 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0155B117731 for ; Sun, 31 Dec 2017 23:48:11 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9547C85CE7; Mon, 1 Jan 2018 08:48:06 +0400 (+04) From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [PATCH 3/5] gdb/copyright.py: Do not forget to remind about MULTIPLE_COPYRIGHT_HEADERS Date: Mon, 01 Jan 2018 04:48:00 -0000 Message-Id: <20180101044801.7201-4-brobecker@adacore.com> In-Reply-To: <20180101044801.7201-1-brobecker@adacore.com> References: <20180101044801.7201-1-brobecker@adacore.com> X-SW-Source: 2018-01/txt/msg00003.txt.bz2 There is a small logical error in the part of the script that dumps the list of files in BY_HAND + MULTIPLE_COPYRIGHT_HEADERS but only checkis the contents of BY_HAND. The issue becomes apparent as soon as BY_HAND is empty. Prevent this from happening by treating the two lists separately, as this allows us to provide a more informative message in the case of MULTIPLE_COPYRIGHT_HEADERS. gdb/ChangeLog: * copyright.py (main): Dump the contents of MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND, even if BY_HAND is empty. --- gdb/ChangeLog | 6 ++++++ gdb/copyright.py | 11 ++++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 929c513a78..27f7c7ffee 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2018-01-01 Joel Brobecker + * copyright.py (main): Dump the contents of + MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND, + even if BY_HAND is empty. + +2018-01-01 Joel Brobecker + * top.c (print_gdb_version): Update Copyright year in version message. diff --git a/gdb/copyright.py b/gdb/copyright.py index dca2d56f98..bb21b21601 100644 --- a/gdb/copyright.py +++ b/gdb/copyright.py @@ -150,11 +150,20 @@ def main (): update_files (update_list) # Remind the user that some files need to be updated by HAND... + + if MULTIPLE_COPYRIGHT_HEADERS: + print + print("\033[31m" + "REMINDER: Multiple copyright headers must be updated by hand:" + "\033[0m") + for filename in MULTIPLE_COPYRIGHT_HEADERS: + print " ", filename + if BY_HAND: print print "\033[31mREMINDER: The following files must be updated by hand." \ "\033[0m" - for filename in BY_HAND + MULTIPLE_COPYRIGHT_HEADERS: + for filename in BY_HAND: print " ", filename ############################################################################ -- 2.11.0