From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simark@simark.ca>,
GDB Patches <gdb-patches@sourceware.org>,
Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [PATCH] Fix type casts losing typedefs and reimplement "whatis" typedef stripping
Date: Mon, 20 Nov 2017 22:35:00 -0000 [thread overview]
Message-ID: <20171120223459.GG318@1170ee0b50d5> (raw)
In-Reply-To: <67474590-af49-a387-9f8b-044bdd689dc7@redhat.com>
On 17-11-20 16:42:48, Pedro Alves wrote:
>
> So in that spirit, I propose starting my making the testcase adjust
> itself, like below, and also test floats of different sizes, leaving
> changing GDB's behavior for a separate consideration/change (using
> the fixed/extended test as baseline).
>
I agree. Some tests fail on 32-bit at the point when they were added,
so tests should match gdb's behaviour. As usual, we can gdb behaviour
after we are sure the behaviour is incorrect.
Beside Simon's review, patch is good to me.
--
Yao (é½å°§)
next prev parent reply other threads:[~2017-11-20 22:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 15:48 Pedro Alves
2017-08-16 20:11 ` Pedro Alves
2017-08-21 10:39 ` Pedro Alves
2017-11-18 20:57 ` Yao Qi
2017-11-18 22:58 ` Simon Marchi
2017-11-20 16:42 ` Pedro Alves
2017-11-20 17:01 ` Simon Marchi
2017-11-20 22:35 ` Yao Qi [this message]
2017-11-20 23:11 ` [pushed] Fix gdb.base/whatis-ptype-typedefs.exp on 32-bit archs (Re: [PATCH] Fix type casts losing typedefs and reimplement "whatis" typedef stripping) Pedro Alves
2017-11-20 23:06 ` [PATCH] Fix type casts losing typedefs and reimplement "whatis" typedef stripping Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120223459.GG318@1170ee0b50d5 \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=pmuldoon@redhat.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox