From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11752 invoked by alias); 20 Nov 2017 22:35:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11740 invoked by uid 89); 20 Nov 2017 22:35:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:sk:static., H*RU:sk:static., H*r:sk:clients, H*r:sk:static. X-HELO: mail-wr0-f178.google.com Received: from mail-wr0-f178.google.com (HELO mail-wr0-f178.google.com) (209.85.128.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Nov 2017 22:35:03 +0000 Received: by mail-wr0-f178.google.com with SMTP id w95so9572333wrc.2 for ; Mon, 20 Nov 2017 14:35:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=BjTnlk/g7WF9V/cOTn3lOszEldAcMsQ76Tu/3P+XiOw=; b=RedpGaVl53Z8FxjoEL0PP4Lvzs71r1pVhxC/n7/TnBWm1PVZSUKm+/m9hEaxsXboO2 ev0fI/A4lVfYhNY19MA4MTxaqbnTqIeveupb2mp6vUsp3hBy75q2PUfkw13uldjBNXJ9 d6hWVvyAhXjsd1TUcRjuastmFmXGkJFGm0ghA9y7PkDpjnNtAMZ6sA65tI704Xwn7vSq BNOc84s3UKLZ60RncFFhnmLe5AGd6fsAtteUcge0QYkTahO0+wwaJNDbHN8mtm8lK2en AU9oSO71eC03PPizTKzqnb7QR78OV1tVgGXPf1okv3JlEj6a9PQPcs0iA221/2V0GQcH 14bg== X-Gm-Message-State: AJaThX7JAshSEwT4+Gze2k4Z6KtZ3INRZLmqrFHmioC4TS8y2EfbjBcn VAfMhXGdNPT6zaLIv7EyD3Q= X-Google-Smtp-Source: AGs4zMZVm+6BBf9+FUomDLWmU7WUax4eFzfV6KYLO5wLGfPU8PSDTVNMWm7hy2gyDXRVLgo4fDteKg== X-Received: by 10.223.150.68 with SMTP id c4mr13816052wra.255.1511217301341; Mon, 20 Nov 2017 14:35:01 -0800 (PST) Received: from 1170ee0b50d5 (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id t63sm4019517wme.35.2017.11.20.14.35.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Nov 2017 14:35:00 -0800 (PST) Date: Mon, 20 Nov 2017 22:35:00 -0000 From: Yao Qi To: Pedro Alves Cc: Simon Marchi , GDB Patches , Phil Muldoon Subject: Re: [PATCH] Fix type casts losing typedefs and reimplement "whatis" typedef stripping Message-ID: <20171120223459.GG318@1170ee0b50d5> References: <1498837699-20897-1-git-send-email-palves@redhat.com> <5225ca30-ef69-040d-3f96-be2e5e87b80b@redhat.com> <4b73fb98-b8c2-9d2f-1981-4660e3c202e6@simark.ca> <67474590-af49-a387-9f8b-044bdd689dc7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <67474590-af49-a387-9f8b-044bdd689dc7@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00425.txt.bz2 On 17-11-20 16:42:48, Pedro Alves wrote: > > So in that spirit, I propose starting my making the testcase adjust > itself, like below, and also test floats of different sizes, leaving > changing GDB's behavior for a separate consideration/change (using > the fixed/extended test as baseline). > I agree. Some tests fail on 32-bit at the point when they were added, so tests should match gdb's behaviour. As usual, we can gdb behaviour after we are sure the behaviour is incorrect. Beside Simon's review, patch is good to me. -- Yao (齐尧)