Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: uweigand@de.ibm.com (Ulrich Weigand)
Cc: macro@imgtec.com (Maciej W. Rozycki), gdb-patches@sourceware.org
Subject: Re: [RFC][06/19] Target FP: Use print_floating in tdep code
Date: Thu, 05 Oct 2017 17:34:00 -0000	[thread overview]
Message-ID: <20171005173417.16E63D835F0@oc3748833570.ibm.com> (raw)
In-Reply-To: <20171005124759.473BBD835F0@oc3748833570.ibm.com> from "Ulrich Weigand" at Oct 05, 2017 02:47:59 PM

Hi Maciej,

> >  Also I find the new formatting of `info all-registers' output 
> > functionally regressed (rather than merely "changed a bit"), e.g.:
> [...]
> > I think we need to get the ability to align output (previously achieved 
> > with formatters, i.e. "%-17.9g" and "%-24.17g") restored; frankly I find 
> > the new format unreadable, which makes me consider it unacceptable.
> 
> I see, this really doesn't look good.  It shouldn't be very difficult
> to fix, since in part 7 of the series I actually introduce routines
> to provide *formatted* output as well.  So I think I'll prepare an
> updated patch set that moves patch 6 after patch 7 and uses those
> formatted print routines in the MIPS back-end.  Once I've done that,
> it would be good if you could re-run your tests to make sure the
> regression is really fixed.

I've now posted an updated patch set just for the target FP printing
changes.  This now applies directly on top of current mainline:
https://sourceware.org/ml/gdb-patches/2017-10/msg00121.html
https://sourceware.org/ml/gdb-patches/2017-10/msg00122.html
https://sourceware.org/ml/gdb-patches/2017-10/msg00123.html

Can you give it a go on MIPS?   Thanks!

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


  parent reply	other threads:[~2017-10-05 17:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 18:21 Ulrich Weigand
2017-10-04 22:26 ` Maciej W. Rozycki
2017-10-05 12:48   ` Ulrich Weigand
2017-10-05 17:01     ` Ulrich Weigand
2017-10-05 17:34     ` Ulrich Weigand [this message]
2017-10-09 15:23       ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171005173417.16E63D835F0@oc3748833570.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox