From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115251 invoked by alias); 5 Oct 2017 17:34:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115234 invoked by uid 89); 5 Oct 2017 17:34:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1337 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Oct 2017 17:34:30 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v95HYMl2110189 for ; Thu, 5 Oct 2017 13:34:28 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ddqek65bn-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 05 Oct 2017 13:34:26 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Oct 2017 18:34:19 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 5 Oct 2017 18:34:17 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v95HYHTS21823628; Thu, 5 Oct 2017 17:34:17 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9769642041; Thu, 5 Oct 2017 18:30:07 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 876254203F; Thu, 5 Oct 2017 18:30:07 +0100 (BST) Received: from oc3748833570.ibm.com (unknown [9.152.213.178]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 5 Oct 2017 18:30:07 +0100 (BST) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 16E63D835F0; Thu, 5 Oct 2017 19:34:17 +0200 (CEST) Subject: Re: [RFC][06/19] Target FP: Use print_floating in tdep code To: uweigand@de.ibm.com (Ulrich Weigand) Date: Thu, 05 Oct 2017 17:34:00 -0000 From: "Ulrich Weigand" Cc: macro@imgtec.com (Maciej W. Rozycki), gdb-patches@sourceware.org In-Reply-To: <20171005124759.473BBD835F0@oc3748833570.ibm.com> from "Ulrich Weigand" at Oct 05, 2017 02:47:59 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17100517-0040-0000-0000-000003FFB04A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17100517-0041-0000-0000-000020A11FBD Message-Id: <20171005173417.16E63D835F0@oc3748833570.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-05_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710050240 X-SW-Source: 2017-10/txt/msg00124.txt.bz2 Hi Maciej, > > Also I find the new formatting of `info all-registers' output > > functionally regressed (rather than merely "changed a bit"), e.g.: > [...] > > I think we need to get the ability to align output (previously achieved > > with formatters, i.e. "%-17.9g" and "%-24.17g") restored; frankly I find > > the new format unreadable, which makes me consider it unacceptable. > > I see, this really doesn't look good. It shouldn't be very difficult > to fix, since in part 7 of the series I actually introduce routines > to provide *formatted* output as well. So I think I'll prepare an > updated patch set that moves patch 6 after patch 7 and uses those > formatted print routines in the MIPS back-end. Once I've done that, > it would be good if you could re-run your tests to make sure the > regression is really fixed. I've now posted an updated patch set just for the target FP printing changes. This now applies directly on top of current mainline: https://sourceware.org/ml/gdb-patches/2017-10/msg00121.html https://sourceware.org/ml/gdb-patches/2017-10/msg00122.html https://sourceware.org/ml/gdb-patches/2017-10/msg00123.html Can you give it a go on MIPS? Thanks! Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com