From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org, qiyaoltc@gmail.com
Subject: Re: [PATCH] nto & lynx x86: call init_target_desc
Date: Fri, 22 Sep 2017 15:14:00 -0000 [thread overview]
Message-ID: <20170922151408.pmyflf36v6jh2xj2@adacore.com> (raw)
In-Reply-To: <1506092746-17214-1-git-send-email-simon.marchi@ericsson.com>
Hi Simon,
On Fri, Sep 22, 2017 at 05:05:46PM +0200, Simon Marchi wrote:
> In gdbserver, target descriptions need to be initialized by calling
> init_target_desc. Because i386_create_target_description is shared with
> GDB, it doesn't do that, the callers must take care of it. These two
> platforms currently don't.
>
> I am not able to build them, so I couldn't test.
>
> gdb/gdbserver/ChangeLog:
>
> * lynx-i386-low.c (lynx_i386_arch_setup): Call init_target_desc.
> * nto-x86-low.c (nto_x86_arch_setup): Likewise.
For LynxOS, go right ahead. I haven't been able to build GDBserver
on LynxOS ever since we switched to C++, as there is no satisfactory
C++ compiler on this platform that I could find or build. I'm hoping
this will change sometime, but in the meantime, best effort is the
best we can do... In this case, it looks quite reasonable.
Thanks for doing that.
--
Joel
next prev parent reply other threads:[~2017-09-22 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 15:06 Simon Marchi
2017-09-22 15:14 ` Joel Brobecker [this message]
2017-10-02 9:00 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922151408.pmyflf36v6jh2xj2@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox