From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128541 invoked by alias); 22 Sep 2017 15:14:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128532 invoked by uid 89); 22 Sep 2017 15:14:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:934, satisfactory X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 15:14:11 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3C1A356547; Fri, 22 Sep 2017 11:14:10 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6AwABg7JfgjZ; Fri, 22 Sep 2017 11:14:10 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0B271560B1; Fri, 22 Sep 2017 11:14:10 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4CFAF8305C; Fri, 22 Sep 2017 08:14:08 -0700 (PDT) Date: Fri, 22 Sep 2017 15:14:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org, qiyaoltc@gmail.com Subject: Re: [PATCH] nto & lynx x86: call init_target_desc Message-ID: <20170922151408.pmyflf36v6jh2xj2@adacore.com> References: <1506092746-17214-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506092746-17214-1-git-send-email-simon.marchi@ericsson.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2017-09/txt/msg00678.txt.bz2 Hi Simon, On Fri, Sep 22, 2017 at 05:05:46PM +0200, Simon Marchi wrote: > In gdbserver, target descriptions need to be initialized by calling > init_target_desc. Because i386_create_target_description is shared with > GDB, it doesn't do that, the callers must take care of it. These two > platforms currently don't. > > I am not able to build them, so I couldn't test. > > gdb/gdbserver/ChangeLog: > > * lynx-i386-low.c (lynx_i386_arch_setup): Call init_target_desc. > * nto-x86-low.c (nto_x86_arch_setup): Likewise. For LynxOS, go right ahead. I haven't been able to build GDBserver on LynxOS ever since we switched to C++, as there is no satisfactory C++ compiler on this platform that I could find or build. I'm hoping this will change sometime, but in the meantime, best effort is the best we can do... In this case, it looks quite reasonable. Thanks for doing that. -- Joel