From: Joel Brobecker <brobecker@adacore.com>
To: Kamil Rytarowski <n54@gmx.com>
Cc: jhb@FreeBSD.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] Correct shell compatibility issue detected with pkgsrc.
Date: Wed, 06 Sep 2017 00:17:00 -0000 [thread overview]
Message-ID: <20170906001747.m3vs7rqzrvsrsss3@adacore.com> (raw)
In-Reply-To: <20170905204239.17030-1-n54@gmx.com>
> String comparison of in a POSIX bourne shell must be done
> with '=', not '=='. For example the NetBSD sh(1) does not
> support it.
>
> gdb/ChangeLog
> 2017-09-05 Kamil Rytarowski <n54@gmx.com>
>
> * config/djgpp/djconfig.sh: Correct shell portability issue
Indeed. Looks good, so go ahead and push to master.
I did notice you were missing a period at the end of the sentence
in the ChangeLog entry above, but it's in the diff. Can you fix it
before pushing?
Thanks!
> ---
> gdb/ChangeLog | 4 ++++
> gdb/config/djgpp/djconfig.sh | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 6d2eae58bc..a8e1837b6a 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,7 @@
> +2017-09-05 Kamil Rytarowski <n54@gmx.com>
> +
> + * config/djgpp/djconfig.sh: Correct shell portability issue.
> +
> 2017-09-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
>
> * objfiles.c (get_objfile_bfd_data): Remove useless obstack_init
> diff --git a/gdb/config/djgpp/djconfig.sh b/gdb/config/djgpp/djconfig.sh
> index 6c0d8698e8..dbaf8f5d76 100644
> --- a/gdb/config/djgpp/djconfig.sh
> +++ b/gdb/config/djgpp/djconfig.sh
> @@ -92,7 +92,7 @@ TMPFILE="${TMPDIR-.}/cfg.tmp"
>
> # We need to skip the build directory if it is a subdirectory of $srcdir,
> # otherwise we will have an infinite recursion on our hands...
> -if test "`pwd`" == "${srcdir}" ; then
> +if test "`pwd`" = "${srcdir}" ; then
> SKIPDIR=""
> SKIPFILES=""
> else
> --
> 2.14.1
--
Joel
next prev parent reply other threads:[~2017-09-06 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 20:55 Kamil Rytarowski
2017-09-06 0:17 ` Joel Brobecker [this message]
2017-09-06 0:30 ` Kamil Rytarowski
2017-09-06 1:04 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906001747.m3vs7rqzrvsrsss3@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=n54@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox