From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49524 invoked by alias); 6 Sep 2017 00:17:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49510 invoked by uid 89); 6 Sep 2017 00:17:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=our X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Sep 2017 00:17:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7DFB256408; Tue, 5 Sep 2017 20:17:50 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OxJ5jvmBQEE2; Tue, 5 Sep 2017 20:17:50 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2589F5611C; Tue, 5 Sep 2017 20:17:50 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 30DF089FA5; Tue, 5 Sep 2017 17:17:47 -0700 (PDT) Date: Wed, 06 Sep 2017 00:17:00 -0000 From: Joel Brobecker To: Kamil Rytarowski Cc: jhb@FreeBSD.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Correct shell compatibility issue detected with pkgsrc. Message-ID: <20170906001747.m3vs7rqzrvsrsss3@adacore.com> References: <20170905204239.17030-1-n54@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170905204239.17030-1-n54@gmx.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2017-09/txt/msg00131.txt.bz2 > String comparison of in a POSIX bourne shell must be done > with '=', not '=='. For example the NetBSD sh(1) does not > support it. > > gdb/ChangeLog > 2017-09-05 Kamil Rytarowski > > * config/djgpp/djconfig.sh: Correct shell portability issue Indeed. Looks good, so go ahead and push to master. I did notice you were missing a period at the end of the sentence in the ChangeLog entry above, but it's in the diff. Can you fix it before pushing? Thanks! > --- > gdb/ChangeLog | 4 ++++ > gdb/config/djgpp/djconfig.sh | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 6d2eae58bc..a8e1837b6a 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,7 @@ > +2017-09-05 Kamil Rytarowski > + > + * config/djgpp/djconfig.sh: Correct shell portability issue. > + > 2017-09-05 Philippe Waroquiers > > * objfiles.c (get_objfile_bfd_data): Remove useless obstack_init > diff --git a/gdb/config/djgpp/djconfig.sh b/gdb/config/djgpp/djconfig.sh > index 6c0d8698e8..dbaf8f5d76 100644 > --- a/gdb/config/djgpp/djconfig.sh > +++ b/gdb/config/djgpp/djconfig.sh > @@ -92,7 +92,7 @@ TMPFILE="${TMPDIR-.}/cfg.tmp" > > # We need to skip the build directory if it is a subdirectory of $srcdir, > # otherwise we will have an infinite recursion on our hands... > -if test "`pwd`" == "${srcdir}" ; then > +if test "`pwd`" = "${srcdir}" ; then > SKIPDIR="" > SKIPFILES="" > else > -- > 2.14.1 -- Joel