From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFA v2 09/13] Return EXT_LANG_BT_ERROR in one more spot in py-framefilter.c
Date: Mon, 14 Aug 2017 03:41:00 -0000 [thread overview]
Message-ID: <20170814034030.20863-10-tom@tromey.com> (raw)
In-Reply-To: <20170814034030.20863-1-tom@tromey.com>
While reading py-framefilter.c, I found one spot where an exception
could be caught but then not be turned into EXT_LANG_BT_ERROR. This
patch fixes this spot.
ChangeLog
2017-08-13 Tom Tromey <tom@tromey.com>
* python/py-framefilter.c (py_print_single_arg): Return
EXT_LANG_BT_ERROR from catch.
---
gdb/ChangeLog | 5 +++++
gdb/python/py-framefilter.c | 1 +
2 files changed, 6 insertions(+)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 630e27b..e5aeb22 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2017-08-13 Tom Tromey <tom@tromey.com>
+ * python/py-framefilter.c (py_print_single_arg): Return
+ EXT_LANG_BT_ERROR from catch.
+
+2017-08-13 Tom Tromey <tom@tromey.com>
+
PR backtrace/15584:
* stack.c (backtrace_command_1): Move some code into no-filters
"if".
diff --git a/gdb/python/py-framefilter.c b/gdb/python/py-framefilter.c
index 76e637c..73f2a31 100644
--- a/gdb/python/py-framefilter.c
+++ b/gdb/python/py-framefilter.c
@@ -457,6 +457,7 @@ py_print_single_arg (struct ui_out *out,
CATCH (except, RETURN_MASK_ERROR)
{
gdbpy_convert_exception (except);
+ retval = EXT_LANG_BT_ERROR;
}
END_CATCH
--
2.9.4
next prev parent reply other threads:[~2017-08-14 3:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 3:41 [RFA v2 00/13] various frame filter fixes and cleanups Tom Tromey
2017-08-14 3:41 ` [RFA v2 08/13] Move some code later in backtrace_command_1 Tom Tromey
2017-08-14 3:41 ` [RFA v2 02/13] Change backtrace_command_1 calling to use flags Tom Tromey
2017-08-14 3:41 ` [RFA v2 10/13] Call wrap_hint in one more spot in py-framefilter.c Tom Tromey
2017-08-14 3:41 ` [RFA v2 04/13] Remove EXT_LANG_BT_COMPLETED Tom Tromey
2017-08-14 3:41 ` [RFA v2 03/13] Allow elision of some filtered frames Tom Tromey
2017-08-14 15:10 ` Eli Zaretskii
2017-08-14 3:41 ` [RFA v2 05/13] Avoid manual resource management in py-framefilter.c Tom Tromey
2017-08-14 3:41 ` [RFA v2 12/13] Simplify exception handling " Tom Tromey
2017-08-14 13:36 ` Pedro Alves
2017-08-14 3:41 ` [RFA v2 01/13] Rationalize "backtrace" command line parsing Tom Tromey
2017-08-14 15:07 ` Eli Zaretskii
2017-08-14 3:41 ` [RFA v2 07/13] Throw a "quit" on a KeyboardException in py-framefilter.c Tom Tromey
2017-08-14 3:41 ` [RFA v2 11/13] Improve "backtrace" help text Tom Tromey
2017-08-14 13:35 ` Pedro Alves
2017-08-14 14:34 ` Tom Tromey
2017-08-14 14:36 ` Pedro Alves
2017-08-14 14:38 ` Tom Tromey
2017-08-14 3:41 ` [RFA v2 13/13] Remove verbose code from backtrace command Tom Tromey
2017-08-14 13:35 ` Pedro Alves
2017-08-14 3:41 ` Tom Tromey [this message]
2017-08-14 3:57 ` [RFA v2 06/13] Allow C-c to work in backtrace in more cases Tom Tromey
2017-08-14 13:20 ` [RFA v2 00/13] various frame filter fixes and cleanups Pedro Alves
2017-08-14 13:57 ` Phil Muldoon
2017-08-14 14:30 ` Pedro Alves
2017-08-14 13:38 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170814034030.20863-10-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox