Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [RFA v2 00/13] various frame filter fixes and cleanups
Date: Mon, 14 Aug 2017 03:41:00 -0000	[thread overview]
Message-ID: <20170814034030.20863-1-tom@tromey.com> (raw)

Here's version 2 of one my frame-filter-related patch series.  This
series rationalizes backtrace command-line parsing, fixes a few bugs,
and adds the ability to not print "elided" frames.

Reviews of v1 mostly were in June, e.g.:
https://sourceware.org/ml/gdb-patches/2017-06/msg00741.html
The series was posted here:
https://sourceware.org/ml/gdb-patches/2017-04/msg00671.html

I believe this new series addresses all the review comments.  However,
there have been changes and additions, so you will probably want to
re-read everything, and especially the new final patch.

There were a few questions last time.  Some are answered in specific
patches, but for the others:

[ about exceptions in py-framefilter.c ]

> Are any of these returning back to the Python runtime?  If so, then
> we can't let C++ exceptions cross it.

I think the answer is no.

> So "bt elide" means "elide the elided frames", not "show me the
> elided frames too".  It's fine with me, though I mildly wonder whether
> users will be confused by the "double negative".

"Elide" means "drop", so really "bt elide" should mean "drop whatever
frames are droppable".  Having "bt elide" mean "show the dropped
frames" would be confusing.  But maybe another word would be better
here, I don't know.

Tom



             reply	other threads:[~2017-08-14  3:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14  3:41 Tom Tromey [this message]
2017-08-14  3:41 ` [RFA v2 01/13] Rationalize "backtrace" command line parsing Tom Tromey
2017-08-14 15:07   ` Eli Zaretskii
2017-08-14  3:41 ` [RFA v2 11/13] Improve "backtrace" help text Tom Tromey
2017-08-14 13:35   ` Pedro Alves
2017-08-14 14:34     ` Tom Tromey
2017-08-14 14:36       ` Pedro Alves
2017-08-14 14:38         ` Tom Tromey
2017-08-14  3:41 ` [RFA v2 13/13] Remove verbose code from backtrace command Tom Tromey
2017-08-14 13:35   ` Pedro Alves
2017-08-14  3:41 ` [RFA v2 09/13] Return EXT_LANG_BT_ERROR in one more spot in py-framefilter.c Tom Tromey
2017-08-14  3:41 ` [RFA v2 07/13] Throw a "quit" on a KeyboardException " Tom Tromey
2017-08-14  3:41 ` [RFA v2 02/13] Change backtrace_command_1 calling to use flags Tom Tromey
2017-08-14  3:41 ` [RFA v2 08/13] Move some code later in backtrace_command_1 Tom Tromey
2017-08-14  3:41 ` [RFA v2 12/13] Simplify exception handling in py-framefilter.c Tom Tromey
2017-08-14 13:36   ` Pedro Alves
2017-08-14  3:41 ` [RFA v2 10/13] Call wrap_hint in one more spot " Tom Tromey
2017-08-14  3:41 ` [RFA v2 04/13] Remove EXT_LANG_BT_COMPLETED Tom Tromey
2017-08-14  3:41 ` [RFA v2 03/13] Allow elision of some filtered frames Tom Tromey
2017-08-14 15:10   ` Eli Zaretskii
2017-08-14  3:41 ` [RFA v2 05/13] Avoid manual resource management in py-framefilter.c Tom Tromey
2017-08-14  3:57 ` [RFA v2 06/13] Allow C-c to work in backtrace in more cases Tom Tromey
2017-08-14 13:20 ` [RFA v2 00/13] various frame filter fixes and cleanups Pedro Alves
2017-08-14 13:57   ` Phil Muldoon
2017-08-14 14:30     ` Pedro Alves
2017-08-14 13:38 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170814034030.20863-1-tom@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox