From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Jiong Wang <jiong.wang@foss.arm.com>,
GDB <gdb-patches@sourceware.org>,
Binutils <binutils@sourceware.org>
Subject: Re: [AArch64][6/6] Core file support for "pauth" feature
Date: Thu, 10 Aug 2017 22:04:00 -0000 [thread overview]
Message-ID: <20170810220402.GF8039@1170ee0b50d5> (raw)
In-Reply-To: <26b4881d-bec9-e2a6-fe96-13f2a44f7b1f@redhat.com>
On 17-08-10 22:32:40, Pedro Alves wrote:
>
> I think there's a misunderstanding. It's not about clarity -- if HWCAP_APIA
> is defined on a !Aarch64 host as some value other than "(1 << 16)", then
> this:
>
> > +++ b/gdb/aarch64-linux-tdep.c
> >
> > - return tdesc_aarch64;
> > + return aarch64_hwcap & HWCAP_APIA ? tdesc_aarch64_pauth : tdesc_aarch64;
> > }
>
> will silently compile to use wrong value.
>
> Might never happen in practice, but why write a potential problem,
> _particularly since you already have to write the fallback
> macro anyway_? What's the advantage of not doing what I suggested?
I want the macro name sync'ed with kernel. However I understand your
point. Let me see if I can ask kernel people change it to HWCAP_ARM64_APIA,
or something else. Kernel patches are not merged yet, as far I as
know.
--
Yao (é½å°§)
next prev parent reply other threads:[~2017-08-10 22:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 12:23 Jiong Wang
2017-08-09 16:49 ` Nick Clifton
[not found] ` <fa73a1a8-aafa-d332-9781-ac61893e7a53@redhat.com>
2017-08-10 21:22 ` Yao Qi
2017-08-10 21:32 ` Pedro Alves
2017-08-10 22:04 ` Yao Qi [this message]
2017-08-11 15:38 ` Yao Qi
2017-08-11 15:55 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810220402.GF8039@1170ee0b50d5 \
--to=qiyaoltc@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=jiong.wang@foss.arm.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox