Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Jiong Wang <jiong.wang@foss.arm.com>,
	GDB <gdb-patches@sourceware.org>,
	Binutils <binutils@sourceware.org>
Subject: Re: [AArch64][6/6] Core file support for "pauth" feature
Date: Thu, 10 Aug 2017 21:22:00 -0000	[thread overview]
Message-ID: <20170810212238.GE8039@1170ee0b50d5> (raw)
In-Reply-To: <fa73a1a8-aafa-d332-9781-ac61893e7a53@redhat.com>

On 17-08-10 12:08:36, Pedro Alves wrote:
> > +#ifndef HWCAP_APIA
> > +/* AArch64 GNU/Linux HWCAP values.  These should be synced with kernel
> > +   definitions.  */
> > +#define HWCAP_APIA (1 << 16)
> > +#endif
> 
> Re. the #ifndef, consider that tdep.h files are included in cross
> debugger builds.  E.g., an x86-hosted gdb cross debugging aarch64.
> Some archs have "namespaced" names like the s390 mips, sparc, etc.
> (e.g., HWCAP_S390_VX) which avoids the case of the names being defined
> on host/target with a different meanings/values, but not all do.
> But even with such names, we always have to provide fallback definitions
> for cross debuggers.  And with that all in mind, and since you're defining
> fallbacks anyway, how about unconditionally defining/using our
> own conflict-resistant versions, like AARCH64_HWCAP_APIA?
> 

I am inclined to use the same macro name as kernel uses.  These macros are
only used in $arch-linux-{tdep,nat}.c, so it is clear that the macros
are about architecture $arch.

-- 
Yao (齐尧)


  parent reply	other threads:[~2017-08-10 21:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09 12:23 Jiong Wang
2017-08-09 16:49 ` Nick Clifton
     [not found] ` <fa73a1a8-aafa-d332-9781-ac61893e7a53@redhat.com>
2017-08-10 21:22   ` Yao Qi [this message]
2017-08-10 21:32     ` Pedro Alves
2017-08-10 22:04       ` Yao Qi
2017-08-11 15:38         ` Yao Qi
2017-08-11 15:55           ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170810212238.GE8039@1170ee0b50d5 \
    --to=qiyaoltc@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jiong.wang@foss.arm.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox