From: Yao Qi <qiyaoltc@gmail.com>
To: Bernhard Heckel <bernhard.heckel@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH V2 2/2] Prologue: Add selftests to x64/x32 architecture.
Date: Tue, 20 Dec 2016 09:20:00 -0000 [thread overview]
Message-ID: <20161220092011.GB18061@E107787-LIN> (raw)
In-Reply-To: <1481896716-1233-3-git-send-email-bernhard.heckel@intel.com>
On 16-12-16 14:58:36, Bernhard Heckel wrote:
> +
> +class code_reader : public abstract_code_reader
> +{
> +public:
> + code_reader (void)
> + {
> + target_memory = 1;
> + }
> +
> + void read (CORE_ADDR memaddr, gdb_byte *buffer, ssize_t len)
> + {
> + read_code (memaddr, buffer, len);
Can we use target_read_code here? It doesn't throw an error if it
can't read. Method 'read' becomes
int read (CORE_ADDR memaddr, gdb_byte *buffer, ssize_t len)
so that we may even share more code with disassembly. See Pedro's
POC patch.
--
Yao (é½å°§)
next prev parent reply other threads:[~2016-12-20 9:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 13:58 [PATCH V2 0/2] AMD64, Prologue: Recognize stack decrementation as prologue operation Bernhard Heckel
2016-12-16 13:59 ` [PATCH V2 1/2] " Bernhard Heckel
2016-12-16 13:59 ` [PATCH V2 2/2] Prologue: Add selftests to x64/x32 architecture Bernhard Heckel
2016-12-19 21:50 ` Yao Qi
2016-12-20 9:20 ` Yao Qi [this message]
2016-12-21 9:27 ` Bernhard Heckel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161220092011.GB18061@E107787-LIN \
--to=qiyaoltc@gmail.com \
--cc=bernhard.heckel@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox