From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32315 invoked by alias); 20 Dec 2016 09:20:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32301 invoked by uid 89); 20 Dec 2016 09:20:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-0.2 required=5.0 tests=AWL,BAYES_05,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy==e5=b0=a7, core_addr, CORE_ADDR, poc?= X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Dec 2016 09:20:36 +0000 Received: by mail-wm0-f65.google.com with SMTP id a20so23194246wme.2 for ; Tue, 20 Dec 2016 01:20:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=2RtGzPXLvvuLg8+Q1P0R5iEvrno0aHJEfef3Aa1/Mx0=; b=e7WXoY7hocqzVRtfjxr/vrKJznGz8WLzBN+kX4h+9Lm5jd8UfgWm0S/87NwTXnPzbv giMBtuJNPEs156LGGHHkLmYsf//NbJHeESjFNRy1jFBSm4q0al4PGu3b1/i/JjZME/MI 2HXSHu5Y2WkbsHcC2cr5U5u4w9jpGfMS4KEh9fS/irMBYyaz6oF9Jzqq/u5Vnwxs4hMi MAwAKI+PT79f1IbwxGrjYdI7P6iD+n/DlUEntl5bbNmqB8Rh9TbxBqL/dnVXWPzAjm8P L4r2LpOy9k/qe3sXCx2nn4XvuJFUG2XJIZ5YvqueAVdHmecbLhf6wi7NZrSatsyJYSUJ bHLA== X-Gm-Message-State: AIkVDXKBgC6UYd7uUU61b+keD1HgZISOIFM4l9xOGY1Q3wd/8I5/3qAm3F478BLHYyosAw== X-Received: by 10.28.142.5 with SMTP id q5mr965865wmd.78.1482225634860; Tue, 20 Dec 2016 01:20:34 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id bj1sm24567077wjc.17.2016.12.20.01.20.32 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 20 Dec 2016 01:20:34 -0800 (PST) Date: Tue, 20 Dec 2016 09:20:00 -0000 From: Yao Qi To: Bernhard Heckel Cc: gdb-patches@sourceware.org Subject: Re: [PATCH V2 2/2] Prologue: Add selftests to x64/x32 architecture. Message-ID: <20161220092011.GB18061@E107787-LIN> References: <1481896716-1233-1-git-send-email-bernhard.heckel@intel.com> <1481896716-1233-3-git-send-email-bernhard.heckel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1481896716-1233-3-git-send-email-bernhard.heckel@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00347.txt.bz2 On 16-12-16 14:58:36, Bernhard Heckel wrote: > + > +class code_reader : public abstract_code_reader > +{ > +public: > + code_reader (void) > + { > + target_memory = 1; > + } > + > + void read (CORE_ADDR memaddr, gdb_byte *buffer, ssize_t len) > + { > + read_code (memaddr, buffer, len); Can we use target_read_code here? It doesn't throw an error if it can't read. Method 'read' becomes int read (CORE_ADDR memaddr, gdb_byte *buffer, ssize_t len) so that we may even share more code with disassembly. See Pedro's POC patch. -- Yao (齐尧)