From: Yao Qi <qiyaoltc@gmail.com>
To: Alan Hayward <alan.hayward@arm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/8] AARCH64 SVE: Initial SVE support
Date: Tue, 13 Dec 2016 11:36:00 -0000 [thread overview]
Message-ID: <20161213113631.GE25542@E107787-LIN> (raw)
In-Reply-To: <D46B0D3D.154CD%alan.hayward@arm.com>
On 16-12-05 12:25:33, Alan Hayward wrote:
> Hi,
>
> I'd like to submit GDB and gdbserver support for ARM's Scalable Vector
> Extension (SVE).
Thanks for your patches...
> In order to support SVE, GDB needs to be able to handle registers which may
> change size at any time whilst the debugged program is running. The target
> architecture descriptions (patch 5) contain a minimum size for each
> variable
> register. GDB (patch 7) and gdbserver (patch 8) must then scale these
> registers
> using the current VG for the target (obtained using ptrace).
> This also requires increasing the maximum register size to 256 bytes
> (patch 1).
There are some coding style issues in patches, some indentation problems,
and spaces after ")", for example.
Your mailer also wrap some lines in the patch, so please fix your mailer
or send patches via git send-email.
There is no ChangeLog entry for each patch, and some rationale are missing
in comments and commit log as well.
--
Yao (é½å°§)
prev parent reply other threads:[~2016-12-13 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 12:25 Alan Hayward
2016-12-13 11:36 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213113631.GE25542@E107787-LIN \
--to=qiyaoltc@gmail.com \
--cc=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox