From: Yao Qi <qiyaoltc@gmail.com>
To: Ambrogino Modigliani <ambrogino.modigliani@gmail.com>
Cc: gdb-patches@sourceware.org, pedro_alves@portugalmail.pt,
ambrogino.modigliani@mail.com
Subject: Re: [PATCH 02/23] Fix spelling mistakes in comments in C source files (gdb)
Date: Mon, 21 Nov 2016 15:43:00 -0000 [thread overview]
Message-ID: <20161121154307.GA24810@E107787-LIN> (raw)
In-Reply-To: <1479663498-30295-3-git-send-email-ambrogino.modigliani@mail.com>
On Sun, Nov 20, 2016 at 06:37:57PM +0100, Ambrogino Modigliani wrote:
> gdb/ChangeLog:
>
> * gdb/ada-lang.c: Fix spelling in comments.
The file name refers to the file location relative to the ChangeLog
file, so don't need "gdb/".
* ada-lang.c: Fix spelling in comments.
>
> gdb/gdbserver/ChangeLog:
>
> * gdb/gdbserver/event-loop.c: Fix spelling in comments.
Likewise, drop "gdb/gdbserver/".
> * gdb/gdbserver/linux-aarch64-low.c: Fix spelling in comments.
> * gdb/gdbserver/linux-arm-low.c: Fix spelling in comments.
> * gdb/gdbserver/linux-low.c: Fix spelling in comments.
> * gdb/gdbserver/linux-ppc-low.c: Fix spelling in comments.
> * gdb/gdbserver/nto-low.c: Fix spelling in comments.
> * gdb/gdbserver/server.c: Fix spelling in comments.
> * gdb/gdbserver/server.h: Fix spelling in comments.
> * gdb/gdbserver/tracepoint.c: Fix spelling in comments.
> * gdb/gdbserver/win32-low.c: Fix spelling in comments.
>
> gdb/testsuite/ChangeLog:
>
> * gdb/testsuite/gdb.base/d10vovly.c: Fix spelling in comments.
drop "gdb/testsuite/".
> * gdb/testsuite/gdb.base/m32rovly.c: Fix spelling in comments.
> * gdb/testsuite/gdb.base/ovlymgr.c: Fix spelling in comments.
> * gdb/testsuite/gdb.base/scope0.c: Fix spelling in comments.
> * gdb/testsuite/gdb.base/sigrepeat.c: Fix spelling in comments.
> * gdb/testsuite/lib/compiler.c: Fix spelling in comments.
> * gdb/testsuite/lib/compiler.cc: Fix spelling in comments.
> diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c
> index 885aadd..ecd1647 100644
> @@ -7253,7 +7253,7 @@ ex:
> /* op3c */
> if (record_full_arch_list_add_reg (regcache, S390_R0_REGNUM + inib[3]))
> return -1;
> - /* fallthru */
> + /* fall through */
fallthru is an annotate to the source to suppress the warnings from
compiler or other static analysis tools. I don't know we need to "fix"
them.
Otherwise, the patch is good to me. Please remove these "fallthru"
replacement in your patch, and send it again. It can be merged.
Ambrogino doesn't have FSF copyright assignment, but I don't think
it is required in this case, because IMO, this patch is not a
"legally significant change"
https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html
and it can be regarded as "tiny change", although the patch is
not tiny, and the url above doesn't explicitly mention "fixing typo"
is not legally significant change.
--
Yao (é½å°§)
next prev parent reply other threads:[~2016-11-21 15:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 17:38 [PATCH 00/23] Fix spelling mistakes in comments Ambrogino Modigliani
2016-11-20 17:38 ` [PATCH 01/23] Fix spelling mistakes in comments in C source files (bfd) Ambrogino Modigliani
2016-11-20 17:39 ` [PATCH 07/23] Fix spelling mistakes in comments in shell scripts Ambrogino Modigliani
2016-11-22 16:07 ` Pedro Alves
2016-11-20 17:39 ` [PATCH 05/23] Fix spelling mistakes in comments in configure scripts Ambrogino Modigliani
2016-11-22 15:55 ` Pedro Alves
2016-11-20 17:39 ` [PATCH 06/23] Fix spelling mistakes in comments in makefiles Ambrogino Modigliani
2016-11-20 17:39 ` [PATCH 02/23] Fix spelling mistakes in comments in C source files (gdb) Ambrogino Modigliani
2016-11-21 15:43 ` Yao Qi [this message]
2016-11-22 15:21 ` Pedro Alves
2016-11-20 17:39 ` [PATCH 03/23] Fix spelling mistakes in comments in C source files (sim) Ambrogino Modigliani
2016-11-20 17:39 ` [PATCH 04/23] Fix spelling mistakes in comments in C source files (rest of modules) Ambrogino Modigliani
2016-11-20 17:39 ` [PATCH 08/23] Fix spelling mistakes in comments in Ada source files Ambrogino Modigliani
2016-11-22 16:08 ` Pedro Alves
2016-11-20 17:40 ` [PATCH 09/23] Fix spelling mistakes in comments in Assembler files Ambrogino Modigliani
2016-11-22 16:10 ` Pedro Alves
2016-11-20 17:41 ` [PATCH 22/23] Fix spelling mistakes in comments in .tbl files Ambrogino Modigliani
2016-11-20 17:41 ` [PATCH 16/23] Fix spelling mistakes in comments in .in files Ambrogino Modigliani
2016-11-20 17:41 ` [PATCH 23/23] Fix spelling mistakes in comments in .y files Ambrogino Modigliani
2016-11-20 17:41 ` [PATCH 20/23] Fix spelling mistakes in comments in .opc files Ambrogino Modigliani
2016-11-20 17:41 ` [PATCH 15/23] Fix spelling mistakes in comments in .igen files Ambrogino Modigliani
2016-11-20 17:41 ` [PATCH 14/23] Fix spelling mistakes in comments in .em files Ambrogino Modigliani
2016-11-20 17:41 ` [PATCH 19/23] Fix spelling mistakes in comments in .m4 files Ambrogino Modigliani
2016-11-20 17:41 ` [PATCH 18/23] Fix spelling mistakes in comments in .l files Ambrogino Modigliani
2016-11-20 17:41 ` [PATCH 12/23] Fix spelling mistakes in comments in .cpu files Ambrogino Modigliani
2016-11-20 17:41 ` [PATCH 13/23] Fix spelling mistakes in comments in .def files Ambrogino Modigliani
2016-11-20 17:41 ` [PATCH 17/23] Fix spelling mistakes in comments in .inc files Ambrogino Modigliani
2016-11-20 17:41 ` [PATCH 21/23] Fix spelling mistakes in comments in .sc files Ambrogino Modigliani
2016-11-20 17:41 ` [PATCH 11/23] Fix spelling mistakes in comments in XML files Ambrogino Modigliani
2016-11-21 20:41 ` Yao Qi
2016-11-20 17:41 ` [PATCH 10/23] Fix spelling mistakes in comments in Expect scripts Ambrogino Modigliani
2016-11-21 22:23 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121154307.GA24810@E107787-LIN \
--to=qiyaoltc@gmail.com \
--cc=ambrogino.modigliani@gmail.com \
--cc=ambrogino.modigliani@mail.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox