From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95184 invoked by alias); 21 Nov 2016 15:43:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95169 invoked by uid 89); 21 Nov 2016 15:43:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=57pm, 57PM, fsf X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Nov 2016 15:43:27 +0000 Received: by mail-wm0-f65.google.com with SMTP id g23so3110175wme.1 for ; Mon, 21 Nov 2016 07:43:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=wr5O6Dntap2XJpMmRBA2HQa9NbSQqIvYRvGMw2gNs5k=; b=bOCnQj/SUO7++01G+YV1J8oHAdMILvS60E78qJkBOja/cw0+PElPvNTlcBiNpXMFo1 9LOOKcypmiZPvVAerp5LZLfGS2+nhNSmblAeDF5cdEGDsivKeDAFYloD6rw1E92I0uc5 T5NrwdWCUYxJ9yzVNHE1+2ISRz1twSUYjfJjFfvdMAAhnQ4noNgo+iqSJ5cQIjj8w3Y+ X668eyxlKslXTGrfMB7TOtKTWp1foER0d6aon6f5g8/6mRbOYDaLt8TaEH05sKZ6H8DP rBCKZc80Jn7at+8rDmmrIIaAc7KsymytM6FrKEWLhX22kOK39BK46eUYEgMq+9GmkzX6 Q6Ig== X-Gm-Message-State: AKaTC00Jn6Da1BV3R1kppsqN99D/uzmrYuE1sqaNQrbwuakWgZrX55sj1FDpJkjs5Sgf8Q== X-Received: by 10.194.246.69 with SMTP id xu5mr9946631wjc.85.1479743004905; Mon, 21 Nov 2016 07:43:24 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 63sm20218198wmg.2.2016.11.21.07.43.22 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 21 Nov 2016 07:43:24 -0800 (PST) Date: Mon, 21 Nov 2016 15:43:00 -0000 From: Yao Qi To: Ambrogino Modigliani Cc: gdb-patches@sourceware.org, pedro_alves@portugalmail.pt, ambrogino.modigliani@mail.com Subject: Re: [PATCH 02/23] Fix spelling mistakes in comments in C source files (gdb) Message-ID: <20161121154307.GA24810@E107787-LIN> References: <1479663498-30295-1-git-send-email-ambrogino.modigliani@mail.com> <1479663498-30295-3-git-send-email-ambrogino.modigliani@mail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1479663498-30295-3-git-send-email-ambrogino.modigliani@mail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00604.txt.bz2 On Sun, Nov 20, 2016 at 06:37:57PM +0100, Ambrogino Modigliani wrote: > gdb/ChangeLog: > > * gdb/ada-lang.c: Fix spelling in comments. The file name refers to the file location relative to the ChangeLog file, so don't need "gdb/". * ada-lang.c: Fix spelling in comments. > > gdb/gdbserver/ChangeLog: > > * gdb/gdbserver/event-loop.c: Fix spelling in comments. Likewise, drop "gdb/gdbserver/". > * gdb/gdbserver/linux-aarch64-low.c: Fix spelling in comments. > * gdb/gdbserver/linux-arm-low.c: Fix spelling in comments. > * gdb/gdbserver/linux-low.c: Fix spelling in comments. > * gdb/gdbserver/linux-ppc-low.c: Fix spelling in comments. > * gdb/gdbserver/nto-low.c: Fix spelling in comments. > * gdb/gdbserver/server.c: Fix spelling in comments. > * gdb/gdbserver/server.h: Fix spelling in comments. > * gdb/gdbserver/tracepoint.c: Fix spelling in comments. > * gdb/gdbserver/win32-low.c: Fix spelling in comments. > > gdb/testsuite/ChangeLog: > > * gdb/testsuite/gdb.base/d10vovly.c: Fix spelling in comments. drop "gdb/testsuite/". > * gdb/testsuite/gdb.base/m32rovly.c: Fix spelling in comments. > * gdb/testsuite/gdb.base/ovlymgr.c: Fix spelling in comments. > * gdb/testsuite/gdb.base/scope0.c: Fix spelling in comments. > * gdb/testsuite/gdb.base/sigrepeat.c: Fix spelling in comments. > * gdb/testsuite/lib/compiler.c: Fix spelling in comments. > * gdb/testsuite/lib/compiler.cc: Fix spelling in comments. > diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c > index 885aadd..ecd1647 100644 > @@ -7253,7 +7253,7 @@ ex: > /* op3c */ > if (record_full_arch_list_add_reg (regcache, S390_R0_REGNUM + inib[3])) > return -1; > - /* fallthru */ > + /* fall through */ fallthru is an annotate to the source to suppress the warnings from compiler or other static analysis tools. I don't know we need to "fix" them. Otherwise, the patch is good to me. Please remove these "fallthru" replacement in your patch, and send it again. It can be merged. Ambrogino doesn't have FSF copyright assignment, but I don't think it is required in this case, because IMO, this patch is not a "legally significant change" https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html and it can be regarded as "tiny change", although the patch is not tiny, and the url above doesn't explicitly mention "fixing typo" is not legally significant change. -- Yao (齐尧)