From: Yao Qi <qiyaoltc@gmail.com>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH] gdbarch: Use an anonymous union for target data in `gdbarch_info'
Date: Tue, 08 Nov 2016 21:20:00 -0000 [thread overview]
Message-ID: <20161108212023.GB1237@chromebook-f19.Home> (raw)
In-Reply-To: <alpine.DEB.2.00.1610181615410.31859@tp.orcam.me.uk>
On Tue, Oct 18, 2016 at 05:19:50PM +0100, Maciej W. Rozycki wrote:
> Index: binutils/gdb/gdbarch.sh
> ===================================================================
> --- binutils.orig/gdb/gdbarch.sh 2016-10-18 02:37:31.000000000 +0100
> +++ binutils/gdb/gdbarch.sh 2016-10-18 02:47:30.048973683 +0100
> @@ -1459,7 +1459,12 @@ struct gdbarch_info
> bfd *abfd;
>
> /* Use default: NULL (ZERO). */
> - void *tdep_info;
> + union
> + {
> + struct gdbarch_tdep_info *tdep_info;
> + struct tdesc_arch_data *tdesc_data;
> + int *id;
> + };
>
Patch is good to me. Could you add comments to each field about
when these fields are used?
next prev parent reply other threads:[~2016-11-08 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 16:20 Maciej W. Rozycki
2016-11-08 8:47 ` Maciej W. Rozycki
2016-11-08 21:20 ` Yao Qi [this message]
2016-11-08 21:43 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108212023.GB1237@chromebook-f19.Home \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@imgtec.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox