From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-134649-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 65721 invoked by alias); 8 Nov 2016 21:20:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 65697 invoked by uid 89); 8 Nov 2016 21:20:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*RU:74.125.82.65, Hx-spam-relays-external:74.125.82.65
X-HELO: mail-wm0-f65.google.com
Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Nov 2016 21:20:35 +0000
Received: by mail-wm0-f65.google.com with SMTP id u144so25243848wmu.0        for <gdb-patches@sourceware.org>; Tue, 08 Nov 2016 13:20:35 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:date:from:to:cc:subject:message-id:references         :mime-version:content-disposition:in-reply-to:user-agent;        bh=/YbTMyUL2pLqlM+QHbH0BXd7c/DXmNrAFNvGXhijJV4=;        b=fHpJqOwN0p9jO+36bdahzZ2mSUxN8w2zgZJc+sM7APm1HhTEufnEG1rnS8G9cfiuoD         S9LdA5Sl24ALhLUOWJPne8W6Vk8uvd6aR+4tNxIGd0eD7cEfFPgnyipGI7lU15PPcfiw         Q2JQxT0jw2Q0EucpNHJsN5A810WSyU15qLSzkNhPyK/vf5rGWn+Qp4Y2eskR8q8l3qqZ         mj8mkDQ+RZrwCVRue/UAe5S+xdu+T5IoQHIQF78+igudss2XCzOF/BzXp3cHCuCh2Gqh         wmaCQG+j277QKAA24Z2BbIFJGUodPzlnj0z6ciDmzSxkLLnRt92V1UYCC8+qkdrPommh         qCBg==
X-Gm-Message-State: ABUngvfFmBUY8Dt3jwi9fj69vb8AMyf4bAINR181EEuh7AaWextJbh9+P/+G+ojrTD0K9w==
X-Received: by 10.28.9.141 with SMTP id 135mr15180054wmj.68.1478640033496;        Tue, 08 Nov 2016 13:20:33 -0800 (PST)
Received: from chromebook-f19.Home ([2a02:c7d:8e80:c00:2202:afff:fef6:5f17])        by smtp.gmail.com with ESMTPSA id 18sm21720266wmr.6.2016.11.08.13.20.32        (version=TLS1_2 cipher=AES128-GCM-SHA256 bits=128/128);        Tue, 08 Nov 2016 13:20:33 -0800 (PST)
Date: Tue, 08 Nov 2016 21:20:00 -0000
From: Yao Qi <qiyaoltc@gmail.com>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH] gdbarch: Use an anonymous union for target data in `gdbarch_info'
Message-ID: <20161108212023.GB1237@chromebook-f19.Home>
References: <alpine.DEB.2.00.1610181615410.31859@tp.orcam.me.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.1610181615410.31859@tp.orcam.me.uk>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-IsSubscribed: yes
X-SW-Source: 2016-11/txt/msg00189.txt.bz2

On Tue, Oct 18, 2016 at 05:19:50PM +0100, Maciej W. Rozycki wrote:
> Index: binutils/gdb/gdbarch.sh
> ===================================================================
> --- binutils.orig/gdb/gdbarch.sh	2016-10-18 02:37:31.000000000 +0100
> +++ binutils/gdb/gdbarch.sh	2016-10-18 02:47:30.048973683 +0100
> @@ -1459,7 +1459,12 @@ struct gdbarch_info
>    bfd *abfd;
>  
>    /* Use default: NULL (ZERO).  */
> -  void *tdep_info;
> +  union
> +    {
> +      struct gdbarch_tdep_info *tdep_info;
> +      struct tdesc_arch_data *tdesc_data;
> +      int *id;
> +    };
>  

Patch is good to me.  Could you add comments to each field about
when these fields are used?