Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Don Breazeal <donb@codesourcery.com>
Cc: gdb-patches@sourceware.org, palves@redhat.com
Subject: Re: [PATCH v3] PR mi/20395 - Fix -var-update for registers in frames 1 and up
Date: Fri, 07 Oct 2016 00:05:00 -0000	[thread overview]
Message-ID: <20161007000520.GT18222@embecosm.com> (raw)
In-Reply-To: <1475614597-109500-1-git-send-email-donb@codesourcery.com>

* Don Breazeal <donb@codesourcery.com> [2016-10-04 13:56:37 -0700]:

> +
> +	    # Check that the addresses are the same.
> +	    if {[expr $bpaddr != $pcval]} then {
> +	        fail "\$pc does not equal address of breakpoint"
> +	    } else {
> +	        pass "\$pc equals address of breakpoint"

This PASS is repeated multiple times and is not unique, which I think
test names are supposed to be.

Otherwise it looks fine to me, though I'm not a maintainer, so can't
approve the patch :)

Thanks,
Andrew


  parent reply	other threads:[~2016-10-07  0:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 21:37 [PATCH] " Don Breazeal
2016-06-08 13:01 ` Andrew Burgess
2016-06-08 13:09   ` Andrew Burgess
2016-06-09  0:48     ` Don Breazeal
2016-06-09 18:23       ` Don Breazeal
     [not found]         ` <20160610103220.GJ26734@embecosm.com>
2016-06-10 21:25           ` Don Breazeal
2016-06-13  9:05             ` Andrew Burgess
2016-06-13 21:54               ` [PATCH v2] " Don Breazeal
2016-06-20 15:32                 ` [PING] " Don Breazeal
2016-07-11 14:48                   ` Don Breazeal
2016-07-20 21:07                     ` Don Breazeal
2016-07-21 16:59                       ` Don Breazeal
2016-07-29 16:13                         ` [PING^4] " Don Breazeal
2016-08-05 18:22                           ` [PING] " Don Breazeal
2016-08-10 15:49                 ` Pedro Alves
2016-10-04 20:56                   ` [PATCH v3] PR mi/20395 - " Don Breazeal
2016-10-05 14:18                     ` Pedro Alves
2016-10-07  0:05                     ` Andrew Burgess [this message]
2016-10-14 16:59                       ` Don Breazeal
2016-10-26 18:04                         ` [PING] " Don Breazeal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161007000520.GT18222@embecosm.com \
    --to=andrew.burgess@embecosm.com \
    --cc=donb@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox