From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116625 invoked by alias); 7 Oct 2016 00:05:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116610 invoked by uid 89); 7 Oct 2016 00:05:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,URIBL_RED autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:sk:host86-, H*RU:sk:host86-, H*r:sk:host86- X-HELO: mail-wm0-f43.google.com Received: from mail-wm0-f43.google.com (HELO mail-wm0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Oct 2016 00:05:31 +0000 Received: by mail-wm0-f43.google.com with SMTP id f193so3054321wmg.0 for ; Thu, 06 Oct 2016 17:05:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QwtLBVx1M1uS1qT6qrnIzD2Jh8zKqxA2kW5QZYf+zN0=; b=DlJ0CCWuRV7HCvpFWpqy9W54y1ETGL1wLs//FPGIqWLSmJuLJGdgu0NFEUTD1zxw/O Sl8AiMJ1sjYV1xMrDomrpXZ8dwgXdbKTT1k1+FKiiVDDREK37x5hGtcC1ZEb3ryU7Ofx mQS5DW0XkQc1WiyLMykUAg2C0WTXROdQVpuEt19qDYJnpzjq4/vkfqRRdzHCypS8n7Ae 0N5Vt25mOOkOlXeHXnJpvATGxmKAqwteCUlPK5B0+9kegWOHrps8Z8s97u21LfH2x4kR N4/u23z+0oXK391/iVHZDppEBDiGTYsgB/994kgJ+PBKavjnPLPrXEuhN78KipAmLeWB o4wg== X-Gm-Message-State: AA6/9RmyFgFSJPieecOEU8Ez6993RkzZfdHTBQ8USLdn09ZF/TKE3frY4NS1XcEsLI0vOg== X-Received: by 10.194.119.100 with SMTP id kt4mr14072743wjb.84.1475798729751; Thu, 06 Oct 2016 17:05:29 -0700 (PDT) Received: from localhost (host86-165-30-128.range86-165.btcentralplus.com. [86.165.30.128]) by smtp.gmail.com with ESMTPSA id iq2sm16914683wjb.19.2016.10.06.17.05.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Oct 2016 17:05:28 -0700 (PDT) Date: Fri, 07 Oct 2016 00:05:00 -0000 From: Andrew Burgess To: Don Breazeal Cc: gdb-patches@sourceware.org, palves@redhat.com Subject: Re: [PATCH v3] PR mi/20395 - Fix -var-update for registers in frames 1 and up Message-ID: <20161007000520.GT18222@embecosm.com> References: <5e305a9a-5582-a2e9-240d-48845ac903d6@redhat.com> <1475614597-109500-1-git-send-email-donb@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475614597-109500-1-git-send-email-donb@codesourcery.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.6.1 (2016-04-27) X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00154.txt.bz2 * Don Breazeal [2016-10-04 13:56:37 -0700]: > + > + # Check that the addresses are the same. > + if {[expr $bpaddr != $pcval]} then { > + fail "\$pc does not equal address of breakpoint" > + } else { > + pass "\$pc equals address of breakpoint" This PASS is repeated multiple times and is not unique, which I think test names are supposed to be. Otherwise it looks fine to me, though I'm not a maintainer, so can't approve the patch :) Thanks, Andrew