From: Artemiy Volkov <artemiyv@acm.org>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [PR gdb/19820] gdb: allow enumeration constants as second operand of BINOP_REPEAT
Date: Wed, 23 Mar 2016 19:00:00 -0000 [thread overview]
Message-ID: <20160323185927.GA12194@gmail.com> (raw)
In-Reply-To: <86poultbc1.fsf@gmail.com>
On Wed, Mar 23, 2016 at 04:20:46PM +0000, Yao Qi wrote:
> Artemiy Volkov <artemiyv@acm.org> writes:
>
> > A couple of tests is also included in this patch to demonstrate that it is
> > working as intended.
> >
> > gdb/Changelog:
> >
> > 2016-03-20 Artemiy Volkov <artemiyv@acm.org>
> >
>
> Add "PR gdb/19820" here...
>
> > * eval.c (evaluate_subexp_standard): Allow TYPE_CODE_ENUM to be
> > the type of BINOP_REPEAT's second operand.
> >
> > gdb/testsuite/Changelog:
> >
> > 2016-03-20 Artemiy Volkov <artemiyv@acm.org>
> >
>
> and here...
>
> > * gdb.base/printcmds.exp: Add artificial arrays tests.
>
> You can reference existing ChangeLog entries.
OK, will do and resend as v2.
>
> Did you run regression tests? If the test is regression free, the patch
> is OK to me with the ChangeLog entry fix I point out above.
Yes, I've made sure that there are no regressions.
Thank you for the review,
Artemiy
next prev parent reply other threads:[~2016-03-23 19:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 19:27 Artemiy Volkov
2016-03-23 16:21 ` Yao Qi
2016-03-23 19:00 ` Artemiy Volkov [this message]
2016-03-23 21:04 ` [PATCH v2] " Artemiy Volkov
2016-04-01 12:15 ` Artemiy Volkov
2016-04-01 13:09 ` Yao Qi
2016-04-01 13:20 ` Artemiy Volkov
2016-04-01 15:02 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323185927.GA12194@gmail.com \
--to=artemiyv@acm.org \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox