From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101118 invoked by alias); 23 Mar 2016 19:00:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101059 invoked by uid 89); 23 Mar 2016 19:00:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:gmail.com, H*RU:gmail.com, Hx-spam-relays-external:gmail.com X-HELO: mail-lf0-f45.google.com Received: from mail-lf0-f45.google.com (HELO mail-lf0-f45.google.com) (209.85.215.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 23 Mar 2016 19:00:41 +0000 Received: by mail-lf0-f45.google.com with SMTP id q73so15989974lfe.2 for ; Wed, 23 Mar 2016 12:00:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=hlhztvfJMe1IBZWKLR/BFXqqT0A71zJNX7JVxGV+2ko=; b=caLnvr6E5HSgzV+/GBsRbMU2YM/tYUMmf7PGzc6en29RwIzKanEoCV0bkcCdQgrG0n H4543zqR7Wgjl6eCAcCBcg0OP6qYK8vsimeEDJbN+qE13fUrufivb9ivcFf0gRz7gBLL S/QBKNr5PL/OsXyQMuC1IPzO3vhyOM2en9rIlZ++b/yF0XpYhGUOG3c1dT95JY8UsfLX ICHujYHMCRomo8NQp/Cl+GSphUSxOjuKZ4vmMw/QVh4sGQHTPVR5CWJJavzQbFqkQbgB TWJinKs3khaQeKsGVyisX+KnN1lccOYX/n+kRfe1BPMYRsRP/tt7DjUEQZugFzlCDTDi oNpQ== X-Gm-Message-State: AD7BkJKHwOBy1/P5DZDm6cIkxUNIzzPyp1CWslnEaS918YNvbsNqXXEok6fMaqnSRGtB1w== X-Received: by 10.25.135.8 with SMTP id j8mr1855358lfd.64.1458759638500; Wed, 23 Mar 2016 12:00:38 -0700 (PDT) Received: from gmail.com (broadband-90-154-70-194.nationalcablenetworks.ru. [90.154.70.194]) by smtp.gmail.com with ESMTPSA id m8sm600637lfe.32.2016.03.23.12.00.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Mar 2016 12:00:37 -0700 (PDT) Date: Wed, 23 Mar 2016 19:00:00 -0000 From: Artemiy Volkov To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [PR gdb/19820] gdb: allow enumeration constants as second operand of BINOP_REPEAT Message-ID: <20160323185927.GA12194@gmail.com> References: <1458494257-30862-1-git-send-email-artemiyv@acm.org> <86poultbc1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86poultbc1.fsf@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00485.txt.bz2 On Wed, Mar 23, 2016 at 04:20:46PM +0000, Yao Qi wrote: > Artemiy Volkov writes: > > > A couple of tests is also included in this patch to demonstrate that it is > > working as intended. > > > > gdb/Changelog: > > > > 2016-03-20 Artemiy Volkov > > > > Add "PR gdb/19820" here... > > > * eval.c (evaluate_subexp_standard): Allow TYPE_CODE_ENUM to be > > the type of BINOP_REPEAT's second operand. > > > > gdb/testsuite/Changelog: > > > > 2016-03-20 Artemiy Volkov > > > > and here... > > > * gdb.base/printcmds.exp: Add artificial arrays tests. > > You can reference existing ChangeLog entries. OK, will do and resend as v2. > > Did you run regression tests? If the test is regression free, the patch > is OK to me with the ChangeLog entry fix I point out above. Yes, I've made sure that there are no regressions. Thank you for the review, Artemiy