From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: koriakin@0x04.net (Marcin Kościelnicki)
Cc: gdb-patches@sourceware.org, koriakin@0x04.net, palves@redhat.com
Subject: Re: [PATCH 1/8] gdb.trace: Fix write_inferior_data_ptr on 32-bit big-endian machines.
Date: Tue, 26 Jan 2016 13:32:00 -0000 [thread overview]
Message-ID: <20160126133215.0A5E125D3@oc7340732750.ibm.com> (raw)
In-Reply-To: <1453471015-9921-1-git-send-email-koriakin@0x04.net> from "=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=" at Jan 22, 2016 02:56:55 PM
Marcin KoÅcielnicki wrote:
> * tracepoint.c (write_inferior_data_ptr): Cast to uintptr_t, so that
> it works properly on big-endian machines where sizeof (CORE_ADDR)
> != sizeof (void *).
This is the same problem that was detected on PowerPC here:
https://sourceware.org/ml/gdb-patches/2015-03/msg00996.html
Unfortunately that patch, while approved, never got committed. It still
seems to be the better solution, since now there's two basically identical
routines write_inferior_data_ptr and write_inferior_data_pointer for no
particular reason ...
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2016-01-26 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 13:57 Marcin Kościelnicki
2016-01-22 14:01 ` Pedro Alves
2016-01-22 14:06 ` Marcin Kościelnicki
2016-01-22 14:10 ` Pedro Alves
2016-01-26 13:32 ` Ulrich Weigand [this message]
2016-01-26 13:45 ` Marcin Kościelnicki
2016-01-26 13:50 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126133215.0A5E125D3@oc7340732750.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=koriakin@0x04.net \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox