From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127197 invoked by alias); 26 Jan 2016 13:32:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127146 invoked by uid 89); 26 Jan 2016 13:32:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: e06smtp16.uk.ibm.com Received: from e06smtp16.uk.ibm.com (HELO e06smtp16.uk.ibm.com) (195.75.94.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 26 Jan 2016 13:32:22 +0000 Received: from localhost by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 26 Jan 2016 13:32:18 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp16.uk.ibm.com (192.168.101.146) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 26 Jan 2016 13:32:16 -0000 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6D27C17D8068 for ; Tue, 26 Jan 2016 13:32:24 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u0QDWG4x36110556 for ; Tue, 26 Jan 2016 13:32:16 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u0QDWFSA007290 for ; Tue, 26 Jan 2016 06:32:15 -0700 Received: from oc7340732750.ibm.com (dyn-9-152-213-148.boeblingen.de.ibm.com [9.152.213.148]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u0QDWFnA007284; Tue, 26 Jan 2016 06:32:15 -0700 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 0A5E125D3; Tue, 26 Jan 2016 14:32:14 +0100 (CET) Subject: Re: [PATCH 1/8] gdb.trace: Fix write_inferior_data_ptr on 32-bit big-endian machines. To: koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) Date: Tue, 26 Jan 2016 13:32:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, koriakin@0x04.net, palves@redhat.com In-Reply-To: <1453471015-9921-1-git-send-email-koriakin@0x04.net> from "=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=" at Jan 22, 2016 02:56:55 PM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20160126133215.0A5E125D3@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16012613-0025-0000-0000-000008BA1DC9 X-SW-Source: 2016-01/txt/msg00651.txt.bz2 Marcin KoÅcielnicki wrote: > * tracepoint.c (write_inferior_data_ptr): Cast to uintptr_t, so that > it works properly on big-endian machines where sizeof (CORE_ADDR) > != sizeof (void *). This is the same problem that was detected on PowerPC here: https://sourceware.org/ml/gdb-patches/2015-03/msg00996.html Unfortunately that patch, while approved, never got committed. It still seems to be the better solution, since now there's two basically identical routines write_inferior_data_ptr and write_inferior_data_pointer for no particular reason ... Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com