From: Mike Frysinger <vapier@gentoo.org>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][RX] Add instraction testcase
Date: Thu, 24 Dec 2015 07:41:00 -0000 [thread overview]
Message-ID: <20151224074133.GI25803@vapier.lan> (raw)
In-Reply-To: <1450719297-15073-2-git-send-email-ysato@users.sourceforge.jp>
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
On 22 Dec 2015 02:34, Yoshinori Sato wrote:
> --- /dev/null
> +++ b/sim/testsuite/sim/rx/ChangeLog
> +Local Variables:
> +mode: change-log
> +left-margin: 8
> +fill-column: 74
> +version-control: never
> +change-log-default-name: "ChangeLog"
> +End:
we don't include these macros in ChangeLog files
> +; Output "pass\n"
> + .macro pass
> + mov.l #0, r1 ; fd == stdout
> + mov.l #pass_str, r2 ; buf == "pass\n"
> + mov.l #5, r3 ; len == 5
> + sub r4,r4
> + bra _write_and_exit
your pass helper prins "pass" and exits, which is good. but a lot of
your tests do:
> + pass
> + exit 0
seems like you should trim the exit from all of them ?
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-24 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 17:35 [PATCH][RX] v2 instructions support Yoshinori Sato
2015-12-21 17:35 ` [PATCH][RX] Add instraction testcase Yoshinori Sato
2015-12-24 7:41 ` Mike Frysinger [this message]
2015-12-24 7:35 ` [PATCH][RX] v2 instructions support Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151224074133.GI25803@vapier.lan \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox