From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123637 invoked by alias); 24 Dec 2015 07:41:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123623 invoked by uid 89); 24 Dec 2015 07:41:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_20,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=trim, Output, bra, UD:l X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 24 Dec 2015 07:41:37 +0000 Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id D8FA8340775; Thu, 24 Dec 2015 07:41:34 +0000 (UTC) Date: Thu, 24 Dec 2015 07:41:00 -0000 From: Mike Frysinger To: Yoshinori Sato Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][RX] Add instraction testcase Message-ID: <20151224074133.GI25803@vapier.lan> Mail-Followup-To: Yoshinori Sato , gdb-patches@sourceware.org References: <1450719297-15073-1-git-send-email-ysato@users.sourceforge.jp> <1450719297-15073-2-git-send-email-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1Y7d0dPL928TPQbc" Content-Disposition: inline In-Reply-To: <1450719297-15073-2-git-send-email-ysato@users.sourceforge.jp> X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00472.txt.bz2 --1Y7d0dPL928TPQbc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-length: 648 On 22 Dec 2015 02:34, Yoshinori Sato wrote: > --- /dev/null > +++ b/sim/testsuite/sim/rx/ChangeLog > +Local Variables: > +mode: change-log > +left-margin: 8 > +fill-column: 74 > +version-control: never > +change-log-default-name: "ChangeLog" > +End: we don't include these macros in ChangeLog files > +; Output "pass\n" > + .macro pass > + mov.l #0, r1 ; fd == stdout > + mov.l #pass_str, r2 ; buf == "pass\n" > + mov.l #5, r3 ; len == 5 > + sub r4,r4 > + bra _write_and_exit your pass helper prins "pass" and exits, which is good. but a lot of your tests do: > + pass > + exit 0 seems like you should trim the exit from all of them ? -mike --1Y7d0dPL928TPQbc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWe6GtAAoJEEFjO5/oN/WBuRkP/AsfeZZHpwjDqp3gXbCWNtlF IhxsPYkn9kx5pVN5Ynj/EqEDJ2gSNNbxFJhzjPNMuJt0EEkpnqsVpcsDF2KlOwds ksCL5hY3SHQrBCVYHPxLN4F3GeiXiNVx6yN+FcbodTWBMyfBI8C0py/fF/3MVlW1 j5OAhC2Yh11CHCg3IlWRDoArM6Kii+cMIB5H3J0rnwQlh3z8XTrLsx0w3TTGp4R5 6CuuTNY6AxHUQYydo8N0M8P8LYs6bzlww1jU4eXgHaKBoK1Eqzk5twVbiG8CWv1K ACFEm/aFHzVDsgNMlc1mOotSgeZabuOcdHZsxsnLXgSiQHb/jiMQnitRUQEibB2R fmIMjXOT+qmOPu0xJuVaJyfgZKX5rovCGW5/H1/nKc7Wg6AvBvg8xAREi+hKsjKd iMm9xvTCgJd5dm40yHcEj9cKvsKUGrDoC3IR8DMaOvJXxgqhpS6rKjOVHFa6lM7n E8nX9n0QVMrbYbWDdkHkApKqExhPdyVBsxPSHT7Cn/y7DFBsdIRb37Fi0xPcr5ja 69OtRseXu6n/DK/M2X7SAlXbJhFshp0yNr31CPQP6BB/QVe9XU0JkhlU/GD9aIWd E2GGy/kdRNbs7qB9VjPlSqBmLAumcWdtkdYvnNHhpq9SSx+dgoTtU3DoAtvv5Prt b9I3mIXOqWhFWpeVK/1T =xQlE -----END PGP SIGNATURE----- --1Y7d0dPL928TPQbc--