Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb.dwarf2: Define and use gdb_target_symbol_prefix for symbol prefixes
Date: Fri, 06 Nov 2015 05:33:00 -0000	[thread overview]
Message-ID: <20151105223329.7404772e@pinnacle.lan> (raw)
In-Reply-To: <563B3580.9030309@redhat.com>

On Thu, 05 Nov 2015 10:54:56 +0000
Pedro Alves <palves@redhat.com> wrote:

> On 11/05/2015 10:46 AM, Pedro Alves wrote:
> >> > I'm willing to make these changes, but I want to first be sure that
> >> > I'm not missing an easier fix.
> 
> BTW, an alternative to the below would be to have two tcl procedures,
> one for asm, and another for C/C++/etc, like
> gdb_target_symbol_prefix_flags_asm / gdb_target_symbol_prefix_flags.
> The C version would just call the asm version and add the double
> quotes.

This is a really good idea.  It means that I don't need to touch
already working test cases contained in .c files.  Also, the SYMBOL
macros contained therein stay simpler and (presumably) easier to
maintain.

I've just posted a patch implementing this idea.  See:

https://sourceware.org/ml/gdb-patches/2015-11/msg00192.html

Thanks!

Kevin


  reply	other threads:[~2015-11-06  5:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30 11:06 Kevin Buettner
2015-10-30 12:06 ` Kevin Buettner
2015-10-30 15:53   ` Pedro Alves
2015-11-05  6:39     ` Kevin Buettner
2015-11-05 10:46       ` Pedro Alves
2015-11-05 10:55         ` Pedro Alves
2015-11-06  5:33           ` Kevin Buettner [this message]
2015-10-30 15:51 ` Pedro Alves
2015-11-04 21:49   ` Kevin Buettner
2015-11-05 10:14     ` Pedro Alves
2015-11-05 20:01       ` Kevin Buettner
2015-11-05 21:19         ` Pedro Alves
2015-11-05 22:26           ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151105223329.7404772e@pinnacle.lan \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox