From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35990 invoked by alias); 6 Nov 2015 05:33:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35978 invoked by uid 89); 6 Nov 2015 05:33:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 06 Nov 2015 05:33:32 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 76B958E718 for ; Fri, 6 Nov 2015 05:33:31 +0000 (UTC) Received: from pinnacle.lan (ovpn-113-161.phx2.redhat.com [10.3.113.161]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA65XUwk006831 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA256 bits=256 verify=NO) for ; Fri, 6 Nov 2015 00:33:31 -0500 Date: Fri, 06 Nov 2015 05:33:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.dwarf2: Define and use gdb_target_symbol_prefix for symbol prefixes Message-ID: <20151105223329.7404772e@pinnacle.lan> In-Reply-To: <563B3580.9030309@redhat.com> References: <20151029212509.438b5642@pinnacle.lan> <20151029222505.3bb590b9@pinnacle.lan> <56335065.1060100@redhat.com> <20151104233946.51336127@pinnacle.lan> <563B3389.20502@redhat.com> <563B3580.9030309@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00193.txt.bz2 On Thu, 05 Nov 2015 10:54:56 +0000 Pedro Alves wrote: > On 11/05/2015 10:46 AM, Pedro Alves wrote: > >> > I'm willing to make these changes, but I want to first be sure that > >> > I'm not missing an easier fix. > > BTW, an alternative to the below would be to have two tcl procedures, > one for asm, and another for C/C++/etc, like > gdb_target_symbol_prefix_flags_asm / gdb_target_symbol_prefix_flags. > The C version would just call the asm version and add the double > quotes. This is a really good idea. It means that I don't need to touch already working test cases contained in .c files. Also, the SYMBOL macros contained therein stay simpler and (presumably) easier to maintain. I've just posted a patch implementing this idea. See: https://sourceware.org/ml/gdb-patches/2015-11/msg00192.html Thanks! Kevin