From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: koriakin@0x04.net (Marcin Kościelnicki)
Cc: brobecker@adacore.com, gdb-patches@sourceware.org,
koriakin@0x04.net (Marcin Kościelnicki)
Subject: Re: [PATCH v2] gdb/record-full: Use xmalloc instead of alloca for temporary memory storage.
Date: Wed, 04 Nov 2015 14:21:00 -0000 [thread overview]
Message-ID: <20151104142100.DD0C9F82F@oc7340732750.ibm.com> (raw)
In-Reply-To: <1446574301-9461-1-git-send-email-koriakin@0x04.net> from "=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=" at Nov 03, 2015 07:11:41 PM
Marcin KoÃ
Âcielnicki <koriakin@0x04.net> wrote:
> On the newly added s390 target, it's possible for a single instruction
> to write practically unbounded amount of memory (eg. MVCLE). This caused
> a stack overflow when alloca was used.
>
> gdb/ChangeLog:
>
> * record-full.c (record_full_exec_insn): Use xmalloc for temporary
> memory storage.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2015-11-04 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 18:42 [PATCH] gdb/record-full: Use xmalloc instead of alloca for large buffers Marcin Kościelnicki
2015-11-03 17:31 ` Ulrich Weigand
2015-11-03 17:36 ` Joel Brobecker
2015-11-03 18:11 ` [PATCH v2] gdb/record-full: Use xmalloc instead of alloca for temporary memory storage Marcin Kościelnicki
2015-11-04 14:21 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104142100.DD0C9F82F@oc7340732750.ibm.com \
--to=uweigand@de.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=koriakin@0x04.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox