From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111171 invoked by alias); 4 Nov 2015 14:21:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109100 invoked by uid 89); 4 Nov 2015 14:21:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp05.uk.ibm.com Received: from e06smtp05.uk.ibm.com (HELO e06smtp05.uk.ibm.com) (195.75.94.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 04 Nov 2015 14:21:07 +0000 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Nov 2015 14:21:04 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 4 Nov 2015 14:21:02 -0000 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id E717D1B0805F for ; Wed, 4 Nov 2015 14:21:15 +0000 (GMT) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tA4EL1ON3015046 for ; Wed, 4 Nov 2015 14:21:01 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tA4EL17Y002307 for ; Wed, 4 Nov 2015 07:21:01 -0700 Received: from oc7340732750.ibm.com (icon-9-164-158-208.megacenter.de.ibm.com [9.164.158.208]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id tA4EL1uc002297; Wed, 4 Nov 2015 07:21:01 -0700 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id DD0C9F82F; Wed, 4 Nov 2015 15:21:00 +0100 (CET) Subject: Re: [PATCH v2] gdb/record-full: Use xmalloc instead of alloca for temporary memory storage. To: koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) Date: Wed, 04 Nov 2015 14:21:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com, gdb-patches@sourceware.org, koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) In-Reply-To: <1446574301-9461-1-git-send-email-koriakin@0x04.net> from "=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=" at Nov 03, 2015 07:11:41 PM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20151104142100.DD0C9F82F@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15110414-0021-0000-0000-000004B379A3 X-SW-Source: 2015-11/txt/msg00137.txt.bz2 Marcin Kościelnicki wrote: > On the newly added s390 target, it's possible for a single instruction > to write practically unbounded amount of memory (eg. MVCLE). This caused > a stack overflow when alloca was used. > > gdb/ChangeLog: > > * record-full.c (record_full_exec_insn): Use xmalloc for temporary > memory storage. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com