Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Doug Evans <dje@google.com>,
	Tristan Gingold <gingold@adacore.com>,
	GDB Patches <gdb-patches@sourceware.org>
Subject: Re: AIX DWARF debugging sections
Date: Mon, 12 Oct 2015 18:34:00 -0000	[thread overview]
Message-ID: <20151012183438.GE3341@adacore.com> (raw)
In-Reply-To: <CAGWvny=kgerJJokbsBz=h=1icH90ePjRCHzpi+GM+_nbiiuhjQ@mail.gmail.com>

> Thanks, David
> 
> * xcoffread (dwrf2_xcoff_names): Add .dwmac and .dwpbtyp.

Looks good to me with just one nit.

> 
> diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
> index 0d49751..5f27859 100644
> --- a/gdb/xcoffread.c
> +++ b/gdb/xcoffread.c
> @@ -159,11 +159,11 @@ static const struct dwarf2_debug_sections dwarf2_xcoff_nam
> es = {
>    { ".dwabrev", NULL },
>    { ".dwline", NULL },
>    { ".dwloc", NULL },
> -  { NULL, NULL }, /* debug_macinfo */
> -  { NULL, NULL }, /* debug_macro */
>    { NULL, NULL }, /* XLC does not generate debug_macinfo for DWARF4 and below *
> /

the GNU Coding Standards ask us that sentences end with a period. So
unfortunately, we're going to have to split that line in two.

  { NULL, NULL }, /* XLC does not generate debug_macinfo for DWARF4
                     and below.  */

> +  { ".dwmac", NULL }, /* debug_macro for DWARF5 and above */
>    { ".dwstr", NULL },
>    { ".dwrnges", NULL },
> -  { NULL, NULL }, /* debug_types */
> +  { ".dwpbtyp", NULL },
>    { NULL, NULL }, /* debug_addr */
>    { ".dwframe", NULL },
>    { NULL, NULL }, /* eh_frame */

-- 
Joel


  reply	other threads:[~2015-10-12 18:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 14:53 David Edelsohn
2015-09-28 13:41 ` Tristan Gingold
2015-10-02 21:32   ` Joel Brobecker
2015-10-02 22:35     ` David Edelsohn
2015-10-06  0:30       ` Doug Evans
2015-10-06 16:52         ` Joel Brobecker
2015-10-06 16:55           ` David Edelsohn
2015-10-06 18:24           ` David Edelsohn
2015-10-06 20:00             ` Doug Evans
2015-10-07 12:49               ` David Edelsohn
2015-10-10  0:04                 ` Joel Brobecker
     [not found]                   ` <CADPb22QmuPeP_QBDNWA4iSi1jsnTvAiAurV8HWGCAYnPoMr+wg@mail.gmail.com>
2015-10-10  2:58                     ` David Edelsohn
2015-10-12 15:50                       ` Joel Brobecker
2015-10-12 17:41                         ` David Edelsohn
2015-10-12 18:34                           ` Joel Brobecker [this message]
2015-10-13 15:33                             ` David Edelsohn
2015-10-13 16:45                               ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151012183438.GE3341@adacore.com \
    --to=brobecker@adacore.com \
    --cc=dje.gcc@gmail.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox