From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126601-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 60870 invoked by alias); 12 Oct 2015 18:34:43 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 60857 invoked by uid 89); 12 Oct 2015 18:34:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2
X-HELO: rock.gnat.com
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 12 Oct 2015 18:34:42 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 55B8E29733;	Mon, 12 Oct 2015 14:34:40 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id wRaAzz0hbmgE; Mon, 12 Oct 2015 14:34:40 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id 1BFD829732;	Mon, 12 Oct 2015 14:34:40 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000)	id A9E1A42BBA; Mon, 12 Oct 2015 11:34:38 -0700 (PDT)
Date: Mon, 12 Oct 2015 18:34:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Doug Evans <dje@google.com>, Tristan Gingold <gingold@adacore.com>,	GDB Patches <gdb-patches@sourceware.org>
Subject: Re: AIX DWARF debugging sections
Message-ID: <20151012183438.GE3341@adacore.com>
References: <CADPb22RhyhWrxLu2vy-TOp7ua97BWBJ6Loa9puoSFiYZq82NBg@mail.gmail.com> <20151006165157.GA3341@adacore.com> <CAGWvnykS9J5cHfbDg4swVhXZdJ+Lzk7JQmikbPrXh2E4p-xshg@mail.gmail.com> <CADPb22Q1s4q7NCzUO5iLt0cT8ewH21RhmHTnyPh7AS=4nhFmsw@mail.gmail.com> <CAGWvnymgdDdzeKNDrjrwwTnO9dPrkcfJjOhJJn9RjGX_+BheJQ@mail.gmail.com> <20151010000433.GB3341@adacore.com> <CADPb22QmuPeP_QBDNWA4iSi1jsnTvAiAurV8HWGCAYnPoMr+wg@mail.gmail.com> <CAGWvnyn51SPQeHvS3xNmc+9J8VwXiL1d94uVR84z_=4EYwdF+Q@mail.gmail.com> <20151012155021.GC3341@adacore.com> <CAGWvny=kgerJJokbsBz=h=1icH90ePjRCHzpi+GM+_nbiiuhjQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGWvny=kgerJJokbsBz=h=1icH90ePjRCHzpi+GM+_nbiiuhjQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SW-Source: 2015-10/txt/msg00165.txt.bz2

> Thanks, David
> 
> * xcoffread (dwrf2_xcoff_names): Add .dwmac and .dwpbtyp.

Looks good to me with just one nit.

> 
> diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
> index 0d49751..5f27859 100644
> --- a/gdb/xcoffread.c
> +++ b/gdb/xcoffread.c
> @@ -159,11 +159,11 @@ static const struct dwarf2_debug_sections dwarf2_xcoff_nam
> es = {
>    { ".dwabrev", NULL },
>    { ".dwline", NULL },
>    { ".dwloc", NULL },
> -  { NULL, NULL }, /* debug_macinfo */
> -  { NULL, NULL }, /* debug_macro */
>    { NULL, NULL }, /* XLC does not generate debug_macinfo for DWARF4 and below *
> /

the GNU Coding Standards ask us that sentences end with a period. So
unfortunately, we're going to have to split that line in two.

  { NULL, NULL }, /* XLC does not generate debug_macinfo for DWARF4
                     and below.  */

> +  { ".dwmac", NULL }, /* debug_macro for DWARF5 and above */
>    { ".dwstr", NULL },
>    { ".dwrnges", NULL },
> -  { NULL, NULL }, /* debug_types */
> +  { ".dwpbtyp", NULL },
>    { NULL, NULL }, /* debug_addr */
>    { ".dwframe", NULL },
>    { NULL, NULL }, /* eh_frame */

-- 
Joel