From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] infcmd.c: Don't attempt to record a NULL value after a finish command
Date: Wed, 30 Sep 2015 13:02:00 -0000 [thread overview]
Message-ID: <20150930060159.6f1d53e6@pinnacle.lan> (raw)
In-Reply-To: <560BD3CE.1040107@redhat.com>
On Wed, 30 Sep 2015 13:21:34 +0100
Pedro Alves <palves@redhat.com> wrote:
> >> I assume that it's record_latest_value that crashes? Isn't the right
> >> fix instead:
> >>
> >> rv->value = get_return_value (func, rv->type);
> >> - rv->value_history_index = record_latest_value (rv->value);
> >> + if (rv->value != NULL)
> >> + rv->value_history_index = record_latest_value (rv->value);
> >>
> >
> > You're right. (I honestly don't know what I was thinking.)
> >
> > Please commit your patch instead.
>
> I don't have a patch -- I wrote that hunk by hand
> in the mail client. :-) Please fix up yours and push it.
Oh, okay.
It's pushed.
Kevin
prev parent reply other threads:[~2015-09-30 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 4:43 Kevin Buettner
2015-09-30 10:27 ` Pedro Alves
2015-09-30 12:17 ` Kevin Buettner
2015-09-30 12:21 ` Pedro Alves
2015-09-30 13:02 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930060159.6f1d53e6@pinnacle.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox