From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126416-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 39293 invoked by alias); 30 Sep 2015 13:02:20 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 39280 invoked by uid 89); 30 Sep 2015 13:02:19 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 30 Sep 2015 13:02:02 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (Postfix) with ESMTPS id 0475CB7A7B	for <gdb-patches@sourceware.org>; Wed, 30 Sep 2015 13:02:00 +0000 (UTC)
Received: from pinnacle.lan ([10.3.113.5])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8UD20xi017910	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA256 bits=256 verify=NO)	for <gdb-patches@sourceware.org>; Wed, 30 Sep 2015 09:02:00 -0400
Date: Wed, 30 Sep 2015 13:02:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] infcmd.c: Don't attempt to record a NULL value after a finish command
Message-ID: <20150930060159.6f1d53e6@pinnacle.lan>
In-Reply-To: <560BD3CE.1040107@redhat.com>
References: <20150929214350.44b076c7@pinnacle.lan>	<560BB90D.70905@redhat.com>	<20150930051736.457e072c@pinnacle.lan>	<560BD3CE.1040107@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-09/txt/msg00656.txt.bz2

On Wed, 30 Sep 2015 13:21:34 +0100
Pedro Alves <palves@redhat.com> wrote:

> >> I assume that it's record_latest_value that crashes?  Isn't the right
> >> fix instead:
> >>
> >> 	  rv->value = get_return_value (func, rv->type);
> >> -	  rv->value_history_index = record_latest_value (rv->value);
> >> +          if (rv->value != NULL)
> >> +  	    rv->value_history_index = record_latest_value (rv->value);
> >>
> > 
> > You're right.  (I honestly don't know what I was thinking.)
> > 
> > Please commit your patch instead.
> 
> I don't have a patch -- I wrote that hunk by hand
> in the mail client.  :-)  Please fix up yours and push it.

Oh, okay.

It's pushed.

Kevin