From: Mike Frysinger <vapier@gentoo.org>
To: James Bowman <james.bowman@ftdichip.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH, FT32] sim: correctly simulate PM write port
Date: Tue, 29 Sep 2015 04:02:00 -0000 [thread overview]
Message-ID: <20150929040218.GB11899@vapier.lan> (raw)
In-Reply-To: <CA9BBF0458F83C4F9051448B941B57D11961FBDD@glaexch3>
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On 28 Sep 2015 23:49, James Bowman wrote:
> + if (cpu->state.pm_unlock)
> + {
> + /* Write to PM */
GNU style uses full sentences and two spaces after the period:
/* Write to PM. */
> + ft32_write_item (sd, dw, cpu->state.pm_addr, d);
> + cpu->state.pm_addr += 4;
> + }
what happens on the hardware when the PM is locked ?
is no error/status/register changed ?
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-29 4:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 23:50 James Bowman
2015-09-29 4:02 ` Mike Frysinger [this message]
2015-09-29 5:05 ` James Bowman
2015-09-30 3:37 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929040218.GB11899@vapier.lan \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=james.bowman@ftdichip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox