From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125721 invoked by alias); 29 Sep 2015 04:02:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125501 invoked by uid 89); 29 Sep 2015 04:02:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_05,SPF_PASS,T_RP_MATCHES_RCVD,UNSUBSCRIBE_BODY autolearn=no version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 29 Sep 2015 04:02:21 +0000 Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id E10B9340885; Tue, 29 Sep 2015 04:02:18 +0000 (UTC) Date: Tue, 29 Sep 2015 04:02:00 -0000 From: Mike Frysinger To: James Bowman Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH, FT32] sim: correctly simulate PM write port Message-ID: <20150929040218.GB11899@vapier.lan> Mail-Followup-To: James Bowman , "gdb-patches@sourceware.org" References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PmA2V3Z32TCmWXqI" Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00620.txt.bz2 --PmA2V3Z32TCmWXqI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-length: 400 On 28 Sep 2015 23:49, James Bowman wrote: > + if (cpu->state.pm_unlock) > + { > + /* Write to PM */ GNU style uses full sentences and two spaces after the period: /* Write to PM. */ > + ft32_write_item (sd, dw, cpu->state.pm_addr, d); > + cpu->state.pm_addr += 4; > + } what happens on the hardware when the PM is locked ? is no error/status/register changed ? -mike --PmA2V3Z32TCmWXqI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWCg1KAAoJEEFjO5/oN/WBc24P/iSsz191Paiz0Uq68hsJq7tr G7KPPL8yAnHJDc7jEFjpk7CdHxD0laW6Fbjbjv+8/VtOgPHm2ZlqAK3DAdKQPlrC NbsRdTWGpWEnDlmWrBOkdRg3w4VEQpQohU5blIh+XdROWPeQXohuVZv5rX0Xw64k Dl9c3rphYB0nNXZNsDs4N2tt/Hby6xIB71QM5Fben2uHZAtUI8Eeul3BOjT1WVI8 wlyHei8Om37efH1tbbAo24XTD4Vor4W/CYZJOJV+pohRopX329clW8z0kxhVCBgF mFlUdw+tmalOzeDkgZCL5SPBFCWNv5pQZWkuRcb40GOdcNamLtZPupvPbP0CWWF5 K1fCFN9wLuRVoefz26RmKlDOUkzmXElOb06Y+x/ah3Ka5CZxves6LAMJM2nzuHSM 4tvtUpmJvAwqKEaZui3R3xkIvqTy0X93my+HIPDtDnQNd5erXmJvYUE3UxGqzLH8 tmZPzm/GBTvWwVYofA8inKcB00xJ/opG96BJoofz11dC124zQ6+EcgBkk3p7HiqP F7yVskdiwb/gY49TbUxjkZDrEkrGAOf97W6LMveB7iuchiZAVMTnVYuig5hvuH89 28KlJiERVPCf8fD5plOz+RFF1DW5CA/0Vxyy/fjmv1quQbu5oX29pAfbj5ERcloY tCZXQFYesaMXxicWN1II =2zdB -----END PGP SIGNATURE----- --PmA2V3Z32TCmWXqI--