Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: [commit] [ppc64le patch v3] Use skip_entrypoint for skip_trampoline_code
Date: Tue, 15 Sep 2015 17:10:00 -0000	[thread overview]
Message-ID: <20150915170959.GA28822@host1.jankratochvil.net> (raw)
In-Reply-To: <20150915165514.B37A22209@oc7340732750.ibm.com>

On Tue, 15 Sep 2015 18:55:14 +0200, Ulrich Weigand wrote:
> Actually, I thought it was fine to have this just be PowerPC-specific.
> 
> The need to skip entrypoints in skip_trampoline_code is only due to the
> quite PowerPC-specific dynamic linker optimization to redirect the PLT
> slot to the local entry point.  I'm not sure if any other target that may
> want to use the skip_entrypoint logic in the future will have the same
> requirement, so it seemed preferable to have that platform-specific.
> 
> In any case, it is probably better to wait with refactoring this into
> common code until such time as there actually *is* a second platform
> that uses skip_entrypoint, so we're clearer about the actual requirements.

OK.

Checked in:
	141c5cc4c44a6ce1a5c628c0f4849a8b1c91d383


Thanks,
Jan


      reply	other threads:[~2015-09-15 17:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07 20:47 [ppc64le] " Jan Kratochvil
2015-09-07 22:01 ` [ppc64le patch v2] " Jan Kratochvil
2015-09-10 15:11   ` [ping for Cc] " Jan Kratochvil
2015-09-10 21:17   ` [ppc64le patch v3] " Jan Kratochvil
2015-09-15 16:39     ` Ulrich Weigand
2015-09-15 16:50       ` Jan Kratochvil
2015-09-15 16:55         ` Ulrich Weigand
2015-09-15 17:10           ` Jan Kratochvil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150915170959.GA28822@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox