From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87908 invoked by alias); 15 Sep 2015 17:10:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87622 invoked by uid 89); 15 Sep 2015 17:10:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Sep 2015 17:10:05 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 3A1ABA302B; Tue, 15 Sep 2015 17:10:04 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-22.ams2.redhat.com [10.36.116.22]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8FH9xUi010306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 15 Sep 2015 13:10:03 -0400 Date: Tue, 15 Sep 2015 17:10:00 -0000 From: Jan Kratochvil To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: [commit] [ppc64le patch v3] Use skip_entrypoint for skip_trampoline_code Message-ID: <20150915170959.GA28822@host1.jankratochvil.net> References: <20150915165019.GA28110@host1.jankratochvil.net> <20150915165514.B37A22209@oc7340732750.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150915165514.B37A22209@oc7340732750.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00351.txt.bz2 On Tue, 15 Sep 2015 18:55:14 +0200, Ulrich Weigand wrote: > Actually, I thought it was fine to have this just be PowerPC-specific. > > The need to skip entrypoints in skip_trampoline_code is only due to the > quite PowerPC-specific dynamic linker optimization to redirect the PLT > slot to the local entry point. I'm not sure if any other target that may > want to use the skip_entrypoint logic in the future will have the same > requirement, so it seemed preferable to have that platform-specific. > > In any case, it is probably better to wait with refactoring this into > common code until such time as there actually *is* a second platform > that uses skip_entrypoint, so we're clearer about the actual requirements. OK. Checked in: 141c5cc4c44a6ce1a5c628c0f4849a8b1c91d383 Thanks, Jan