From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Sergio Durigan Junior <sergiodj@redhat.com>
Subject: Re: [patch] Do not skip prologue for asm (.S) files
Date: Thu, 25 Jun 2015 20:37:00 -0000 [thread overview]
Message-ID: <20150625203732.GA1724@host1.jankratochvil.net> (raw)
In-Reply-To: <047d7bfeb318a3caf305195d7da8@google.com>
On Thu, 25 Jun 2015 22:30:14 +0200, Doug Evans wrote:
> Jan Kratochvil writes:
> > On Tue, 23 Jun 2015 22:35:01 +0200, Jan Kratochvil wrote:
> > > On Tue, 23 Jun 2015 01:46:08 +0200, Doug Evans wrote:
> > > > but it doesn't update sal.section nor sal.line.
> > >
> > > OK, I agree that seems wrong.
> >
> > I do not agree, it seems correct to me.
>
> I was wondering if things were correct, not stating they weren't.
Fine with that, just you have convinced me initially there is really a bug.
> Fortunately, I think there's a better way: instead of setting
> locations_valid check the language at the place where we care.
I am sure fine with that.
> Ok with this change.
Just there is now also [patchv2].
Thanks,
Jan
next prev parent reply other threads:[~2015-06-25 20:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 20:30 Doug Evans
2015-06-25 20:37 ` Jan Kratochvil [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-20 15:44 Jan Kratochvil
2015-06-21 22:52 ` Doug Evans
2015-06-22 21:16 ` Jan Kratochvil
2015-06-22 23:46 ` Doug Evans
2015-06-23 20:35 ` Jan Kratochvil
2015-06-24 20:20 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625203732.GA1724@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox