From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4336 invoked by alias); 25 Jun 2015 20:37:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4104 invoked by uid 89); 25 Jun 2015 20:37:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Jun 2015 20:37:41 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id E7C3C359D33; Thu, 25 Jun 2015 20:37:39 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5PKbXaO012704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 25 Jun 2015 16:37:37 -0400 Date: Thu, 25 Jun 2015 20:37:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: gdb-patches , Sergio Durigan Junior Subject: Re: [patch] Do not skip prologue for asm (.S) files Message-ID: <20150625203732.GA1724@host1.jankratochvil.net> References: <047d7bfeb318a3caf305195d7da8@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <047d7bfeb318a3caf305195d7da8@google.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00557.txt.bz2 On Thu, 25 Jun 2015 22:30:14 +0200, Doug Evans wrote: > Jan Kratochvil writes: > > On Tue, 23 Jun 2015 22:35:01 +0200, Jan Kratochvil wrote: > > > On Tue, 23 Jun 2015 01:46:08 +0200, Doug Evans wrote: > > > > but it doesn't update sal.section nor sal.line. > > > > > > OK, I agree that seems wrong. > > > > I do not agree, it seems correct to me. > > I was wondering if things were correct, not stating they weren't. Fine with that, just you have convinced me initially there is really a bug. > Fortunately, I think there's a better way: instead of setting > locations_valid check the language at the place where we care. I am sure fine with that. > Ok with this change. Just there is now also [patchv2]. Thanks, Jan