From: Gary Benson <gbenson@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [OB PATCH] Don't assume File-I/O mode bits match the host's format
Date: Tue, 09 Jun 2015 13:28:00 -0000 [thread overview]
Message-ID: <20150609132751.GA28953@blade.nx> (raw)
In-Reply-To: <mvmzj49f3x1.fsf@hawking.suse.de>
Andreas Schwab wrote:
> Gary Benson <gbenson@redhat.com> writes:
>
> > + if (fileio_mode & ~FILEIO_S_SUPPORTED)
> > + return -1;
>
> > + if (fileio_mode & FILEIO_S_IFCHR)
> > + mode |= S_IFCHR;
>
> FILEIO_S_SUPPORTED doesn't include FILEIO_S_IFCHR, so this is never
> true.
Good spot!
It seems to me FILEIO_S_SUPPORTED should include FILEIO_S_IFCHR, would
anybody object if I made that change?
Thanks,
Gary
--
http://gbenson.net/
prev parent reply other threads:[~2015-06-09 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 12:32 Gary Benson
2015-06-09 12:43 ` Andreas Schwab
2015-06-09 13:28 ` Gary Benson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609132751.GA28953@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox