From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123392-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7765 invoked by alias); 9 Jun 2015 13:28:00 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 7752 invoked by uid 89); 9 Jun 2015 13:27:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 09 Jun 2015 13:27:54 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (Postfix) with ESMTPS id 295D8345B4D;	Tue,  9 Jun 2015 13:27:53 +0000 (UTC)
Received: from blade.nx (ovpn-116-112.ams2.redhat.com [10.36.116.112])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t59DRq86002356;	Tue, 9 Jun 2015 09:27:52 -0400
Received: by blade.nx (Postfix, from userid 1000)	id 92BF12626FB; Tue,  9 Jun 2015 14:27:51 +0100 (BST)
Date: Tue, 09 Jun 2015 13:28:00 -0000
From: Gary Benson <gbenson@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [OB PATCH] Don't assume File-I/O mode bits match the host's format
Message-ID: <20150609132751.GA28953@blade.nx>
References: <1433853129-9470-1-git-send-email-gbenson@redhat.com> <mvmzj49f3x1.fsf@hawking.suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <mvmzj49f3x1.fsf@hawking.suse.de>
X-IsSubscribed: yes
X-SW-Source: 2015-06/txt/msg00127.txt.bz2

Andreas Schwab wrote:
> Gary Benson <gbenson@redhat.com> writes:
> 
> > +  if (fileio_mode & ~FILEIO_S_SUPPORTED)
> > +    return -1;
> 
> > +  if (fileio_mode & FILEIO_S_IFCHR)
> > +    mode |= S_IFCHR;
> 
> FILEIO_S_SUPPORTED doesn't include FILEIO_S_IFCHR, so this is never
> true.

Good spot!

It seems to me FILEIO_S_SUPPORTED should include FILEIO_S_IFCHR, would
anybody object if I made that change?

Thanks,
Gary

-- 
http://gbenson.net/